github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #125557 from MikeSpreitzer/apf-int-test-tolerate-more-noise

Browse Source 
Increase noise margin for TestConcurrencyIsolation
This commit is contained in:
Kubernetes Prow Robot
2024-07-08 16:21:34 -07:00
committed by GitHub
parent 8c7ee69212 e8bb82cdf0
commit 4a48562a81
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/integration/apiserver/flowcontrol/concurrency_util_test.go
View File

@@ -280,9 +280,9 @@ func TestConcurrencyIsolation(t *testing.T) {
// standard deviation divided by mean, for a class of traffic is a characterization of all the noise that applied to // standard deviation divided by mean, for a class of traffic is a characterization of all the noise that applied to
// that class. We found that noxu1 generally had a much bigger CV than noxu2. This makes sense, because noxu1 probes // that class. We found that noxu1 generally had a much bigger CV than noxu2. This makes sense, because noxu1 probes
// more behavior --- the waiting in queues. So we take the minimum of the two as an indicator of the relative amount // more behavior --- the waiting in queues. So we take the minimum of the two as an indicator of the relative amount
// of noise that comes from all the other behavior. Currently, we use 2 times the experienced coefficient of variation // of noise that comes from all the other behavior. Currently, we use 3 times the experienced coefficient of variation
// as the margin of error. // as the margin of error.
margin := 2 * math.Min(noxu1LatStats.cv, noxu2LatStats.cv) margin := 3 * math.Min(noxu1LatStats.cv, noxu2LatStats.cv)
t.Logf("Error margin is %v", margin) t.Logf("Error margin is %v", margin)
isConcurrencyExpected := func(name string, observed float64, expected float64) bool { isConcurrencyExpected := func(name string, observed float64, expected float64) bool {