github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

deflake TestWebSocketClient_HeartbeatSucceeds

Browse Source 
Change-Id: I1f3331255ed81183b25ec24084c00d0cf7dfb510
This commit is contained in:
Antonio Ojea
2023-09-25 10:31:46 +00:00
parent c6bb90aeea
commit 4a74958b2d
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/client-go/tools/remotecommand/websocket_test.go
View File

@@ -1057,8 +1057,7 @@ func TestWebSocketClient_HeartbeatSucceeds(t *testing.T) {
for { for {
_, _, err := conn.ReadMessage() _, _, err := conn.ReadMessage()
if err != nil { if err != nil {
t.Logf("server err reading message: %v", err) break
return
} }
} }
})) }))
@@ -1085,7 +1084,11 @@ func TestWebSocketClient_HeartbeatSucceeds(t *testing.T) {
return pongHandler(msg) return pongHandler(msg)
}) })
go heartbeat.start() go heartbeat.start()
var wg sync.WaitGroup
wg.Add(1)
go func() { go func() {
defer wg.Done()
for { for {
_, _, err := client.ReadMessage() _, _, err := client.ReadMessage()
if err != nil { if err != nil {
@@ -1107,6 +1110,7 @@ func TestWebSocketClient_HeartbeatSucceeds(t *testing.T) {
close(heartbeat.closer) close(heartbeat.closer)
t.Errorf("unexpected heartbeat timeout") t.Errorf("unexpected heartbeat timeout")
} }
wg.Wait()
} }
func TestWebSocketClient_StreamsAndExpectedErrors(t *testing.T) { func TestWebSocketClient_StreamsAndExpectedErrors(t *testing.T) {