Duplicate service port name can't be validated

Duplicate service port name can't be validated Duplicate service port name can't be validated Duplicate service port name can't be validated
2015-04-29 10:08:42 +08:00
parent be15e84e83
commit 4bb594b34d
2 changed files with 5 additions and 3 deletions
--- a/pkg/api/validation/validation.go
+++ b/pkg/api/validation/validation.go
@@ -1028,6 +1028,8 @@ func validateServicePort(sp *api.ServicePort, requireName bool, allNames *util.S
 			allErrs = append(allErrs, errs.NewFieldInvalid("name", sp.Name, dns1123LabelErrorMsg))
 		} else if allNames.Has(sp.Name) {
 			allErrs = append(allErrs, errs.NewFieldDuplicate("name", sp.Name))
+		} else {
+			allNames.Insert(sp.Name)
 		}
 	}