github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid strings.Join which is expensive

Browse Source
This commit is contained in:
Wojciech Tyczynski 2017-05-18 12:05:29 +02:00
parent 5464c39333
commit 4d29c8608f
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/proxy/iptables/proxier.go
View File

@ -1543,7 +1543,15 @@ func (proxier *Proxier) clearUDPConntrackForPort(port int) {
// Join all words with spaces, terminate with newline and write to buf. // Join all words with spaces, terminate with newline and write to buf.
func writeLine(buf *bytes.Buffer, words ...string) { func writeLine(buf *bytes.Buffer, words ...string) {
buf.WriteString(strings.Join(words, " ") + "\n") // We avoid strings.Join for performance reasons.
for i := range words {
buf.WriteString(words[i])
if i < len(words)-1 {
buf.WriteByte(' ')
} else {
buf.WriteByte('\n')
}
}
} }
func isLocalIP(ip string) (bool, error) { func isLocalIP(ip string) (bool, error) {