github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix of review comments. Will squash later.

Browse Source 
Including:
- Remove external usage of resource name vars
- Add commments about why we export field helpers
This commit is contained in:
Xiangyang Chu
2019-07-18 09:12:28 +08:00
parent 313044abd7
commit 4ef227c682
3 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/cmd/proxy.sh
View File

@@ -27,10 +27,10 @@ run_kubectl_local_proxy_tests() {
start-proxy
check-curl-proxy-code /api/kubernetes 404
check-curl-proxy-code /api/v1/namespaces 200
if kube::test::if_supports_resource "${metrics:?}" ; then
if kube::test::if_supports_resource "metrics" ; then
check-curl-proxy-code /metrics 200
fi
if kube::test::if_supports_resource "${static:?}" ; then
if kube::test::if_supports_resource "static" ; then
check-curl-proxy-code /static/ 200
fi
stop-proxy
@@ -45,7 +45,7 @@ run_kubectl_local_proxy_tests() {
start-proxy /custom
check-curl-proxy-code /custom/api/kubernetes 404
check-curl-proxy-code /custom/api/v1/namespaces 200
if kube::test::if_supports_resource "${metrics}" ; then
if kube::test::if_supports_resource "metrics" ; then
check-curl-proxy-code /custom/metrics 200
fi
check-curl-proxy-code /custom/api/v1/namespaces 200