github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update DefaultLoadBalancerName method and add that its deprecated

Browse Source
This commit is contained in:
morrislaw 2018-08-15 20:54:29 -04:00
parent 522db8fce8
commit 4f8fe9d922
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/cloudprovider/cloud.go
View File

@ -62,9 +62,11 @@ type Clusters interface {
Master(ctx context.Context, clusterName string) (string, error) Master(ctx context.Context, clusterName string) (string, error)
} }
// DefaultLoadBalancerName is for getting the load balancer name. It should eventually be removed // (DEPRECATED) DefaultLoadBalancerName is the default load balancer name that is called from
// because there is an interface method, LoadBalancer.GetLoadBalancerName, which can be implemented // LoadBalancer.GetLoadBalancerName. Use this method to maintain backward compatible names for
// per provider and this neutral implementation won't fit every cloud provider's requirements. // LoadBalancers that were created prior to Kubernetes v1.12. In the future, each provider should
// replace this method call in GetLoadBalancerName with a provider-specific implementation that
// is less cryptic than the Service's UUID.
func DefaultLoadBalancerName(service *v1.Service) string { func DefaultLoadBalancerName(service *v1.Service) string {
//GCE requires that the name of a load balancer starts with a lower case letter. //GCE requires that the name of a load balancer starts with a lower case letter.
ret := "a" + string(service.UID) ret := "a" + string(service.UID)