github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Updated comment for DefaultLoadBalancerName to provide further context

Browse Source
This commit is contained in:
morrislaw 2018-08-14 18:20:03 -04:00
parent cd786bda64
commit 522db8fce8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/cloudprovider/cloud.go
View File

@ -62,8 +62,9 @@ type Clusters interface {
Master(ctx context.Context, clusterName string) (string, error) Master(ctx context.Context, clusterName string) (string, error)
} }
// TODO(#6812): Use a shorter name that's less likely to be longer than cloud // DefaultLoadBalancerName is for getting the load balancer name. It should eventually be removed
// providers' name length limits. // because there is an interface method, LoadBalancer.GetLoadBalancerName, which can be implemented
// per provider and this neutral implementation won't fit every cloud provider's requirements.
func DefaultLoadBalancerName(service *v1.Service) string { func DefaultLoadBalancerName(service *v1.Service) string {
//GCE requires that the name of a load balancer starts with a lower case letter. //GCE requires that the name of a load balancer starts with a lower case letter.
ret := "a" + string(service.UID) ret := "a" + string(service.UID)