github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #79631 from Huang-Wei/sched-q-flake

Browse Source 
Fixed a racing issue in scheduler UT
This commit is contained in:
Kubernetes Prow Robot
2019-08-08 10:03:19 -07:00
committed by GitHub
parent 3030a9d927 139d9a1b1e
commit 5257266e9b
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/scheduler/internal/queue/scheduling_queue_test.go
View File

@@ -293,12 +293,12 @@ func TestPriorityQueue_AddUnschedulableIfNotPresent(t *testing.T) {
} }
} }
// TestPriorityQueue_AddUnschedulableIfNotPresent_Backoff tests scenario when // TestPriorityQueue_AddUnschedulableIfNotPresent_Backoff tests the scenarios when
// AddUnschedulableIfNotPresent is called asynchronously pods in and before // AddUnschedulableIfNotPresent is called asynchronously.
// current scheduling cycle will be put back to activeQueue if we were trying // Pods in and before current scheduling cycle will be put back to activeQueue
// to schedule them when we received move request. // if we were trying to schedule them when we received move request.
func TestPriorityQueue_AddUnschedulableIfNotPresent_Backoff(t *testing.T) { func TestPriorityQueue_AddUnschedulableIfNotPresent_Backoff(t *testing.T) {
q := NewPriorityQueue(nil, nil) q := NewPriorityQueueWithClock(nil, clock.NewFakeClock(time.Now()), nil)
totalNum := 10 totalNum := 10
expectedPods := make([]v1.Pod, 0, totalNum) expectedPods := make([]v1.Pod, 0, totalNum)
for i := 0; i < totalNum; i++ { for i := 0; i < totalNum; i++ {
@@ -348,7 +348,9 @@ func TestPriorityQueue_AddUnschedulableIfNotPresent_Backoff(t *testing.T) {
}, },
} }
q.AddUnschedulableIfNotPresent(unschedulablePod, oldCycle) if err := q.AddUnschedulableIfNotPresent(unschedulablePod, oldCycle); err != nil {
t.Errorf("Failed to call AddUnschedulableIfNotPresent(%v): %v", unschedulablePod.Name, err)
}
} }
// Since there was a move request at the same cycle as "oldCycle", these pods // Since there was a move request at the same cycle as "oldCycle", these pods