github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FitError: return details of failure on each node

Browse Source
This commit is contained in:
Hongchao Deng
2016-01-20 19:38:34 -08:00
parent 4e04a289d8
commit 5331ffc82f
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
plugin/pkg/scheduler/generic_scheduler.go
View File

@@ -17,6 +17,7 @@ limitations under the License.
package scheduler package scheduler
import ( import (
"bytes"
"fmt" "fmt"
"math/rand" "math/rand"
"sort" "sort"
@@ -41,17 +42,15 @@ type FitError struct {
var ErrNoNodesAvailable = fmt.Errorf("no nodes available to schedule pods") var ErrNoNodesAvailable = fmt.Errorf("no nodes available to schedule pods")
// implementation of the error interface // Error returns detailed information of why the pod failed to fit on each node
func (f *FitError) Error() string { func (f *FitError) Error() string {
var reason string var buf bytes.Buffer
// We iterate over all nodes for logging purposes, even though we only return one reason from one node buf.WriteString(fmt.Sprintf("pod (%s) failed to fit in any node\n", f.Pod.Name))
for node, predicateList := range f.FailedPredicates { for node, predicateList := range f.FailedPredicates {
glog.V(2).Infof("Failed to find fit for pod %v on node %s: %s", f.Pod.Name, node, strings.Join(predicateList.List(), ",")) reason := fmt.Sprintf("fit failure on node (%s): %s\n", node, strings.Join(predicateList.List(), ","))
if len(reason) == 0 { buf.WriteString(reason)
reason, _ = predicateList.PopAny()
} }
} return buf.String()
return fmt.Sprintf("Failed for reason %s and possibly others", reason)
} }
type genericScheduler struct { type genericScheduler struct {