Correcting all go vet errors

pkg/runtime/conversion_generator.go

@@ -92,7 +92,7 @@ func (g *conversionGenerator) GenerateConversionsForType(version string, reflect
 	}
 	internalObjType := reflect.TypeOf(internalObj)
 	if internalObjType.Kind() != reflect.Ptr {
-		return fmt.Errorf("created object should be of type Ptr: ", internalObjType.Kind())
+		return fmt.Errorf("created object should be of type Ptr: %v", internalObjType.Kind())
 	}
 	inErr := g.generateConversionsBetween(reflection, internalObjType.Elem())
 	outErr := g.generateConversionsBetween(internalObjType.Elem(), reflection)
@@ -173,7 +173,6 @@ func (g *conversionGenerator) generateConversionsBetween(inType, outType reflect
 		// All simple types should be handled correctly with default conversion.
 		return nil
 	}
-	panic("This should never happen")
 }
 
 func isComplexType(reflection reflect.Type) bool {

pkg/runtime/embedded_test.go

@@ -153,7 +153,7 @@ func TestEmbeddedObject(t *testing.T) {
 	outer := &EmbeddedTest{
 		ID: "outer",
 		Object: runtime.EmbeddedObject{
-			&EmbeddedTest{
+			Object: &EmbeddedTest{
 				ID: "inner",
 			},
 		},
@@ -212,7 +212,7 @@ func TestDeepCopyOfEmbeddedObject(t *testing.T) {
 	original := &EmbeddedTest{
 		ID: "outer",
 		Object: runtime.EmbeddedObject{
-			&EmbeddedTest{
+			Object: &EmbeddedTest{
 				ID: "inner",
 			},
 		},

pkg/runtime/scheme_test.go

@@ -207,7 +207,7 @@ func TestExternalToInternalMapping(t *testing.T) {
 		encoded string
 	}{
 		{
-			&InternalOptionalExtensionType{Extension: runtime.EmbeddedObject{nil}},
+			&InternalOptionalExtensionType{Extension: runtime.EmbeddedObject{Object: nil}},
 			`{"kind":"OptionalExtensionType","apiVersion":"testExternal"}`,
 		},
 	}
@@ -245,13 +245,13 @@ func TestExtensionMapping(t *testing.T) {
 		encoded string
 	}{
 		{
-			&InternalExtensionType{Extension: runtime.EmbeddedObject{&ExtensionA{TestString: "foo"}}},
+			&InternalExtensionType{Extension: runtime.EmbeddedObject{Object: &ExtensionA{TestString: "foo"}}},
 			`{"kind":"ExtensionType","apiVersion":"testExternal","extension":{"kind":"A","testString":"foo"}}`,
 		}, {
-			&InternalExtensionType{Extension: runtime.EmbeddedObject{&ExtensionB{TestString: "bar"}}},
+			&InternalExtensionType{Extension: runtime.EmbeddedObject{Object: &ExtensionB{TestString: "bar"}}},
 			`{"kind":"ExtensionType","apiVersion":"testExternal","extension":{"kind":"B","testString":"bar"}}`,
 		}, {
-			&InternalExtensionType{Extension: runtime.EmbeddedObject{nil}},
+			&InternalExtensionType{Extension: runtime.EmbeddedObject{Object: nil}},
 			`{"kind":"ExtensionType","apiVersion":"testExternal","extension":null}`,
 		},
 	}