github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve clarity and guidance in provisioner waiting message

Browse Source 
Signed-off-by: torredil <torredil@amazon.com>
This commit is contained in:
torredil
2023-05-25 17:26:06 +00:00
parent ffc0346400
commit 5d18f47149
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/controller/volume/persistentvolume/pv_controller.go
View File

@@ -1835,11 +1835,15 @@ func (ctrl *PersistentVolumeController) provisionClaimOperationExternal(
newClaim, err := ctrl.setClaimProvisioner(ctx, claim, provisionerName) newClaim, err := ctrl.setClaimProvisioner(ctx, claim, provisionerName)
if err != nil { if err != nil {
// Save failed, the controller will retry in the next sync // Save failed, the controller will retry in the next sync
strerr := fmt.Sprintf("Error saving claim: %v", err)
logger.V(2).Info("Error saving claim", "PVC", klog.KObj(claim), "err", err) logger.V(2).Info("Error saving claim", "PVC", klog.KObj(claim), "err", err)
ctrl.eventRecorder.Event(claim, v1.EventTypeWarning, events.ProvisioningFailed, strerr)
return provisionerName, err return provisionerName, err
} }
claim = newClaim claim = newClaim
msg := fmt.Sprintf("waiting for a volume to be created, either by external provisioner %q or manually created by system administrator", provisionerName) msg := fmt.Sprintf("Waiting for a volume to be created either by the external provisioner '%s' "+
"or manually by the system administrator. If volume creation is delayed, please verify that "+
"the provisioner is running and correctly registered.", provisionerName)
// External provisioner has been requested for provisioning the volume // External provisioner has been requested for provisioning the volume
// Report an event and wait for external provisioner to finish // Report an event and wait for external provisioner to finish
ctrl.eventRecorder.Event(claim, v1.EventTypeNormal, events.ExternalProvisioning, msg) ctrl.eventRecorder.Event(claim, v1.EventTypeNormal, events.ExternalProvisioning, msg)