Unify events registry to be generic.
This commit is contained in:
Wojciech Tyczynski
241
pkg/registry/event/etcd/etcd_test.go
Normal file
241
pkg/registry/event/etcd/etcd_test.go
Normal file
@@ -0,0 +1,241 @@
|
||||
/*
|
||||
Copyright 2014 The Kubernetes Authors All rights reserved.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
package etcd
|
||||
|
||||
import (
|
||||
"reflect"
|
||||
"testing"
|
||||
|
||||
"k8s.io/kubernetes/pkg/api"
|
||||
"k8s.io/kubernetes/pkg/api/errors"
|
||||
"k8s.io/kubernetes/pkg/api/testapi"
|
||||
etcdgeneric "k8s.io/kubernetes/pkg/registry/generic/etcd"
|
||||
"k8s.io/kubernetes/pkg/runtime"
|
||||
etcdstorage "k8s.io/kubernetes/pkg/storage/etcd"
|
||||
"k8s.io/kubernetes/pkg/tools"
|
||||
"k8s.io/kubernetes/pkg/tools/etcdtest"
|
||||
"k8s.io/kubernetes/pkg/util"
|
||||
|
||||
"github.com/coreos/go-etcd/etcd"
|
||||
)
|
||||
|
||||
var testTTL uint64 = 60
|
||||
|
||||
func NewTestEventStorage(t *testing.T) (*tools.FakeEtcdClient, *REST) {
|
||||
f := tools.NewFakeEtcdClient(t)
|
||||
f.TestIndex = true
|
||||
|
||||
s := etcdstorage.NewEtcdStorage(f, testapi.Codec(), etcdtest.PathPrefix())
|
||||
return f, NewStorage(s, testTTL)
|
||||
}
|
||||
|
||||
func TestEventCreate(t *testing.T) {
|
||||
eventA := &api.Event{
|
||||
ObjectMeta: api.ObjectMeta{Name: "foo", Namespace: api.NamespaceDefault},
|
||||
Reason: "forTesting",
|
||||
InvolvedObject: api.ObjectReference{Name: "bar", Namespace: api.NamespaceDefault},
|
||||
}
|
||||
eventB := &api.Event{
|
||||
ObjectMeta: api.ObjectMeta{Name: "foo", Namespace: api.NamespaceDefault},
|
||||
Reason: "forTesting",
|
||||
InvolvedObject: api.ObjectReference{Name: "bar", Namespace: api.NamespaceDefault},
|
||||
}
|
||||
|
||||
nodeWithEventA := tools.EtcdResponseWithError{
|
||||
R: &etcd.Response{
|
||||
Node: &etcd.Node{
|
||||
Value: runtime.EncodeOrDie(testapi.Codec(), eventA),
|
||||
ModifiedIndex: 1,
|
||||
CreatedIndex: 1,
|
||||
TTL: int64(testTTL),
|
||||
},
|
||||
},
|
||||
E: nil,
|
||||
}
|
||||
|
||||
emptyNode := tools.EtcdResponseWithError{
|
||||
R: &etcd.Response{},
|
||||
E: tools.EtcdErrorNotFound,
|
||||
}
|
||||
|
||||
ctx := api.NewDefaultContext()
|
||||
key := "foo"
|
||||
path, err := etcdgeneric.NamespaceKeyFunc(ctx, "/events", key)
|
||||
path = etcdtest.AddPrefix(path)
|
||||
if err != nil {
|
||||
t.Errorf("Unexpected error: %v", err)
|
||||
}
|
||||
|
||||
table := map[string]struct {
|
||||
existing tools.EtcdResponseWithError
|
||||
expect tools.EtcdResponseWithError
|
||||
toCreate runtime.Object
|
||||
errOK func(error) bool
|
||||
}{
|
||||
"normal": {
|
||||
existing: emptyNode,
|
||||
expect: nodeWithEventA,
|
||||
toCreate: eventA,
|
||||
errOK: func(err error) bool { return err == nil },
|
||||
},
|
||||
"preExisting": {
|
||||
existing: nodeWithEventA,
|
||||
expect: nodeWithEventA,
|
||||
toCreate: eventB,
|
||||
errOK: errors.IsAlreadyExists,
|
||||
},
|
||||
}
|
||||
|
||||
for name, item := range table {
|
||||
fakeClient, storage := NewTestEventStorage(t)
|
||||
fakeClient.Data[path] = item.existing
|
||||
_, err := storage.Create(ctx, item.toCreate)
|
||||
if !item.errOK(err) {
|
||||
t.Errorf("%v: unexpected error: %v", name, err)
|
||||
}
|
||||
|
||||
// nullify fields set by infrastructure
|
||||
received := fakeClient.Data[path]
|
||||
var event api.Event
|
||||
if err := testapi.Codec().DecodeInto([]byte(received.R.Node.Value), &event); err != nil {
|
||||
t.Errorf("unexpected error: %v", err)
|
||||
}
|
||||
event.ObjectMeta.CreationTimestamp = util.Time{}
|
||||
event.ObjectMeta.UID = ""
|
||||
received.R.Node.Value = runtime.EncodeOrDie(testapi.Codec(), &event)
|
||||
|
||||
if e, a := item.expect, received; !reflect.DeepEqual(e, a) {
|
||||
t.Errorf("%v:\n%s", name, util.ObjectDiff(e, a))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestEventUpdate(t *testing.T) {
|
||||
eventA := &api.Event{
|
||||
ObjectMeta: api.ObjectMeta{Name: "foo", Namespace: api.NamespaceDefault},
|
||||
Reason: "forTesting",
|
||||
InvolvedObject: api.ObjectReference{Name: "foo", Namespace: api.NamespaceDefault},
|
||||
}
|
||||
eventB := &api.Event{
|
||||
ObjectMeta: api.ObjectMeta{Name: "foo", Namespace: api.NamespaceDefault},
|
||||
Reason: "for testing again",
|
||||
InvolvedObject: api.ObjectReference{Name: "foo", Namespace: api.NamespaceDefault},
|
||||
}
|
||||
eventC := &api.Event{
|
||||
ObjectMeta: api.ObjectMeta{Name: "foo", Namespace: api.NamespaceDefault, ResourceVersion: "1"},
|
||||
Reason: "for testing again something else",
|
||||
InvolvedObject: api.ObjectReference{Name: "foo", Namespace: api.NamespaceDefault},
|
||||
}
|
||||
|
||||
nodeWithEventA := tools.EtcdResponseWithError{
|
||||
R: &etcd.Response{
|
||||
Node: &etcd.Node{
|
||||
Value: runtime.EncodeOrDie(testapi.Codec(), eventA),
|
||||
ModifiedIndex: 1,
|
||||
CreatedIndex: 1,
|
||||
TTL: int64(testTTL),
|
||||
},
|
||||
},
|
||||
E: nil,
|
||||
}
|
||||
|
||||
nodeWithEventB := tools.EtcdResponseWithError{
|
||||
R: &etcd.Response{
|
||||
Node: &etcd.Node{
|
||||
Value: runtime.EncodeOrDie(testapi.Codec(), eventB),
|
||||
ModifiedIndex: 1,
|
||||
CreatedIndex: 1,
|
||||
TTL: int64(testTTL),
|
||||
},
|
||||
},
|
||||
E: nil,
|
||||
}
|
||||
|
||||
nodeWithEventC := tools.EtcdResponseWithError{
|
||||
R: &etcd.Response{
|
||||
Node: &etcd.Node{
|
||||
Value: runtime.EncodeOrDie(testapi.Codec(), eventC),
|
||||
ModifiedIndex: 1,
|
||||
CreatedIndex: 1,
|
||||
TTL: int64(testTTL),
|
||||
},
|
||||
},
|
||||
E: nil,
|
||||
}
|
||||
|
||||
emptyNode := tools.EtcdResponseWithError{
|
||||
R: &etcd.Response{},
|
||||
E: tools.EtcdErrorNotFound,
|
||||
}
|
||||
|
||||
ctx := api.NewDefaultContext()
|
||||
key := "foo"
|
||||
path, err := etcdgeneric.NamespaceKeyFunc(ctx, "/events", key)
|
||||
path = etcdtest.AddPrefix(path)
|
||||
if err != nil {
|
||||
t.Errorf("Unexpected error: %v", err)
|
||||
}
|
||||
|
||||
table := map[string]struct {
|
||||
existing tools.EtcdResponseWithError
|
||||
expect tools.EtcdResponseWithError
|
||||
toUpdate runtime.Object
|
||||
errOK func(error) bool
|
||||
}{
|
||||
"doesNotExist": {
|
||||
existing: emptyNode,
|
||||
expect: nodeWithEventA,
|
||||
toUpdate: eventA,
|
||||
errOK: func(err error) bool { return err == nil },
|
||||
},
|
||||
"doesNotExist2": {
|
||||
existing: emptyNode,
|
||||
expect: nodeWithEventB,
|
||||
toUpdate: eventB,
|
||||
errOK: func(err error) bool { return err == nil },
|
||||
},
|
||||
"replaceExisting": {
|
||||
existing: nodeWithEventA,
|
||||
expect: nodeWithEventC,
|
||||
toUpdate: eventC,
|
||||
errOK: func(err error) bool { return err == nil },
|
||||
},
|
||||
}
|
||||
|
||||
for name, item := range table {
|
||||
fakeClient, storage := NewTestEventStorage(t)
|
||||
fakeClient.Data[path] = item.existing
|
||||
_, _, err := storage.Update(ctx, item.toUpdate)
|
||||
if !item.errOK(err) {
|
||||
t.Errorf("%v: unexpected error: %v", name, err)
|
||||
}
|
||||
|
||||
// nullify fields set by infrastructure
|
||||
received := fakeClient.Data[path]
|
||||
var event api.Event
|
||||
if err := testapi.Codec().DecodeInto([]byte(received.R.Node.Value), &event); err != nil {
|
||||
t.Errorf("unexpected error: %v", err)
|
||||
}
|
||||
event.ObjectMeta.CreationTimestamp = util.Time{}
|
||||
event.ObjectMeta.UID = ""
|
||||
received.R.Node.Value = runtime.EncodeOrDie(testapi.Codec(), &event)
|
||||
|
||||
if e, a := item.expect, received; !reflect.DeepEqual(e, a) {
|
||||
t.Errorf("%v:\n%s", name, util.ObjectGoPrintDiff(e, a))
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user