github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Log cluster-scoped owners referencing namespaced owners, avoid retrying lookups forever

Browse Source 
If a cluster-scoped dependent references a namespace-scoped owner,
this is an invalid relationship, and the lookup will never succeed in attemptToDelete.

Short-circuit requeueing in attemptToDelete and log.
This commit is contained in:
Jordan Liggitt
2020-11-12 12:24:41 -05:00
parent 221e4aa2c2
commit 603a0b016e
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/controller/garbagecollector/operations.go
View File

@@ -65,7 +65,13 @@ func (gc *GarbageCollector) getObject(item objectReference) (*metav1.PartialObje
if err != nil {
return nil, err
}
return gc.metadataClient.Resource(resource).Namespace(resourceDefaultNamespace(namespaced, item.Namespace)).Get(context.TODO(), item.Name, metav1.GetOptions{})
namespace := resourceDefaultNamespace(namespaced, item.Namespace)
if namespaced && len(namespace) == 0 {
// the type is namespaced, but we have no namespace coordinate.
// the only way this can happen is if a cluster-scoped object referenced this type as an owner.
return nil, namespacedOwnerOfClusterScopedObjectErr
}
return gc.metadataClient.Resource(resource).Namespace(namespace).Get(context.TODO(), item.Name, metav1.GetOptions{})
}
func (gc *GarbageCollector) patchObject(item objectReference, patch []byte, pt types.PatchType) (*metav1.PartialObjectMetadata, error) {