remove last part of deprecated metrics
This commit is contained in:
		@@ -65,18 +65,6 @@ var (
 | 
				
			|||||||
		[]string{"transformation_type", "transformer_prefix", "status"},
 | 
							[]string{"transformation_type", "transformer_prefix", "status"},
 | 
				
			||||||
	)
 | 
						)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	deprecatedTransformerFailuresTotal = metrics.NewCounterVec(
 | 
					 | 
				
			||||||
		&metrics.CounterOpts{
 | 
					 | 
				
			||||||
			Namespace:         namespace,
 | 
					 | 
				
			||||||
			Subsystem:         subsystem,
 | 
					 | 
				
			||||||
			Name:              "transformation_failures_total",
 | 
					 | 
				
			||||||
			Help:              "Total number of failed transformation operations.",
 | 
					 | 
				
			||||||
			StabilityLevel:    metrics.ALPHA,
 | 
					 | 
				
			||||||
			DeprecatedVersion: "1.15.0",
 | 
					 | 
				
			||||||
		},
 | 
					 | 
				
			||||||
		[]string{"transformation_type"},
 | 
					 | 
				
			||||||
	)
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	envelopeTransformationCacheMissTotal = metrics.NewCounter(
 | 
						envelopeTransformationCacheMissTotal = metrics.NewCounter(
 | 
				
			||||||
		&metrics.CounterOpts{
 | 
							&metrics.CounterOpts{
 | 
				
			||||||
			Namespace:      namespace,
 | 
								Namespace:      namespace,
 | 
				
			||||||
@@ -115,7 +103,6 @@ func RegisterMetrics() {
 | 
				
			|||||||
	registerMetrics.Do(func() {
 | 
						registerMetrics.Do(func() {
 | 
				
			||||||
		legacyregistry.MustRegister(transformerLatencies)
 | 
							legacyregistry.MustRegister(transformerLatencies)
 | 
				
			||||||
		legacyregistry.MustRegister(transformerOperationsTotal)
 | 
							legacyregistry.MustRegister(transformerOperationsTotal)
 | 
				
			||||||
		legacyregistry.MustRegister(deprecatedTransformerFailuresTotal)
 | 
					 | 
				
			||||||
		legacyregistry.MustRegister(envelopeTransformationCacheMissTotal)
 | 
							legacyregistry.MustRegister(envelopeTransformationCacheMissTotal)
 | 
				
			||||||
		legacyregistry.MustRegister(dataKeyGenerationLatencies)
 | 
							legacyregistry.MustRegister(dataKeyGenerationLatencies)
 | 
				
			||||||
		legacyregistry.MustRegister(dataKeyGenerationFailuresTotal)
 | 
							legacyregistry.MustRegister(dataKeyGenerationFailuresTotal)
 | 
				
			||||||
@@ -130,8 +117,6 @@ func RecordTransformation(transformationType, transformerPrefix string, start ti
 | 
				
			|||||||
	switch {
 | 
						switch {
 | 
				
			||||||
	case err == nil:
 | 
						case err == nil:
 | 
				
			||||||
		transformerLatencies.WithLabelValues(transformationType).Observe(sinceInSeconds(start))
 | 
							transformerLatencies.WithLabelValues(transformationType).Observe(sinceInSeconds(start))
 | 
				
			||||||
	default:
 | 
					 | 
				
			||||||
		deprecatedTransformerFailuresTotal.WithLabelValues(transformationType).Inc()
 | 
					 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -105,7 +105,6 @@ func TestTotals(t *testing.T) {
 | 
				
			|||||||
			tt.prefix.TransformToStorage([]byte("value"), nil)
 | 
								tt.prefix.TransformToStorage([]byte("value"), nil)
 | 
				
			||||||
			tt.prefix.TransformFromStorage([]byte("k8s:enc:kms:v1:value"), nil)
 | 
								tt.prefix.TransformFromStorage([]byte("k8s:enc:kms:v1:value"), nil)
 | 
				
			||||||
			defer transformerOperationsTotal.Reset()
 | 
								defer transformerOperationsTotal.Reset()
 | 
				
			||||||
			defer deprecatedTransformerFailuresTotal.Reset()
 | 
					 | 
				
			||||||
			if err := testutil.GatherAndCompare(legacyregistry.DefaultGatherer, strings.NewReader(tt.want), tt.metrics...); err != nil {
 | 
								if err := testutil.GatherAndCompare(legacyregistry.DefaultGatherer, strings.NewReader(tt.want), tt.metrics...); err != nil {
 | 
				
			||||||
				t.Fatal(err)
 | 
									t.Fatal(err)
 | 
				
			||||||
			}
 | 
								}
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -38,17 +38,6 @@ var (
 | 
				
			|||||||
		[]string{"verb", "url"},
 | 
							[]string{"verb", "url"},
 | 
				
			||||||
	)
 | 
						)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	// deprecatedRequestLatency is deprecated, please use requestLatency.
 | 
					 | 
				
			||||||
	deprecatedRequestLatency = k8smetrics.NewHistogramVec(
 | 
					 | 
				
			||||||
		&k8smetrics.HistogramOpts{
 | 
					 | 
				
			||||||
			Name:              "rest_client_request_latency_seconds",
 | 
					 | 
				
			||||||
			Help:              "Request latency in seconds. Broken down by verb and URL.",
 | 
					 | 
				
			||||||
			Buckets:           k8smetrics.ExponentialBuckets(0.001, 2, 10),
 | 
					 | 
				
			||||||
			DeprecatedVersion: "1.14.0",
 | 
					 | 
				
			||||||
		},
 | 
					 | 
				
			||||||
		[]string{"verb", "url"},
 | 
					 | 
				
			||||||
	)
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	requestResult = k8smetrics.NewCounterVec(
 | 
						requestResult = k8smetrics.NewCounterVec(
 | 
				
			||||||
		&k8smetrics.CounterOpts{
 | 
							&k8smetrics.CounterOpts{
 | 
				
			||||||
			Name: "rest_client_requests_total",
 | 
								Name: "rest_client_requests_total",
 | 
				
			||||||
@@ -110,26 +99,23 @@ var (
 | 
				
			|||||||
func init() {
 | 
					func init() {
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	legacyregistry.MustRegister(requestLatency)
 | 
						legacyregistry.MustRegister(requestLatency)
 | 
				
			||||||
	legacyregistry.MustRegister(deprecatedRequestLatency)
 | 
					 | 
				
			||||||
	legacyregistry.MustRegister(requestResult)
 | 
						legacyregistry.MustRegister(requestResult)
 | 
				
			||||||
	legacyregistry.RawMustRegister(execPluginCertTTL)
 | 
						legacyregistry.RawMustRegister(execPluginCertTTL)
 | 
				
			||||||
	legacyregistry.MustRegister(execPluginCertRotation)
 | 
						legacyregistry.MustRegister(execPluginCertRotation)
 | 
				
			||||||
	metrics.Register(metrics.RegisterOpts{
 | 
						metrics.Register(metrics.RegisterOpts{
 | 
				
			||||||
		ClientCertExpiry:      execPluginCertTTLAdapter,
 | 
							ClientCertExpiry:      execPluginCertTTLAdapter,
 | 
				
			||||||
		ClientCertRotationAge: &rotationAdapter{m: execPluginCertRotation},
 | 
							ClientCertRotationAge: &rotationAdapter{m: execPluginCertRotation},
 | 
				
			||||||
		RequestLatency:        &latencyAdapter{m: requestLatency, dm: deprecatedRequestLatency},
 | 
							RequestLatency:        &latencyAdapter{m: requestLatency},
 | 
				
			||||||
		RequestResult:         &resultAdapter{requestResult},
 | 
							RequestResult:         &resultAdapter{requestResult},
 | 
				
			||||||
	})
 | 
						})
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
type latencyAdapter struct {
 | 
					type latencyAdapter struct {
 | 
				
			||||||
	m *k8smetrics.HistogramVec
 | 
						m *k8smetrics.HistogramVec
 | 
				
			||||||
	dm *k8smetrics.HistogramVec
 | 
					 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
func (l *latencyAdapter) Observe(verb string, u url.URL, latency time.Duration) {
 | 
					func (l *latencyAdapter) Observe(verb string, u url.URL, latency time.Duration) {
 | 
				
			||||||
	l.m.WithLabelValues(verb, u.String()).Observe(latency.Seconds())
 | 
						l.m.WithLabelValues(verb, u.String()).Observe(latency.Seconds())
 | 
				
			||||||
	l.dm.WithLabelValues(verb, u.String()).Observe(latency.Seconds())
 | 
					 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
type resultAdapter struct {
 | 
					type resultAdapter struct {
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user