Address golint warnings
This commit is contained in:
@@ -28,6 +28,7 @@ require (
|
|||||||
golang.org/x/time v0.0.0-20200630173020-3af7569d3a1e
|
golang.org/x/time v0.0.0-20200630173020-3af7569d3a1e
|
||||||
k8s.io/api v0.0.0
|
k8s.io/api v0.0.0
|
||||||
k8s.io/apimachinery v0.0.0
|
k8s.io/apimachinery v0.0.0
|
||||||
|
k8s.io/klog v1.0.0
|
||||||
k8s.io/klog/v2 v2.4.0
|
k8s.io/klog/v2 v2.4.0
|
||||||
k8s.io/utils v0.0.0-20201110183641-67b214c5f920
|
k8s.io/utils v0.0.0-20201110183641-67b214c5f920
|
||||||
sigs.k8s.io/yaml v1.2.0
|
sigs.k8s.io/yaml v1.2.0
|
||||||
|
2
staging/src/k8s.io/client-go/go.sum
generated
2
staging/src/k8s.io/client-go/go.sum
generated
@@ -428,6 +428,8 @@ honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWh
|
|||||||
honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=
|
honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=
|
||||||
honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
|
honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
|
||||||
k8s.io/gengo v0.0.0-20200413195148-3a45101e95ac/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
|
k8s.io/gengo v0.0.0-20200413195148-3a45101e95ac/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
|
||||||
|
k8s.io/klog v1.0.0 h1:Pt+yjF5aB1xDSVbau4VsWe+dQNzA0qv1LlXdC2dF6Q8=
|
||||||
|
k8s.io/klog v1.0.0/go.mod h1:4Bi6QPql/J/LkTDqv7R/cd3hPo4k2DG6Ptcz060Ez5I=
|
||||||
k8s.io/klog/v2 v2.0.0/go.mod h1:PBfzABfn139FHAV07az/IF9Wp1bkk3vpT2XSJ76fSDE=
|
k8s.io/klog/v2 v2.0.0/go.mod h1:PBfzABfn139FHAV07az/IF9Wp1bkk3vpT2XSJ76fSDE=
|
||||||
k8s.io/klog/v2 v2.4.0 h1:7+X0fUguPyrKEC4WjH8iGDg3laWgMo5tMnRTIGTTxGQ=
|
k8s.io/klog/v2 v2.4.0 h1:7+X0fUguPyrKEC4WjH8iGDg3laWgMo5tMnRTIGTTxGQ=
|
||||||
k8s.io/klog/v2 v2.4.0/go.mod h1:Od+F08eJP+W3HUb4pSrPpgp9DGU4GzlpG/TmITuYh/Y=
|
k8s.io/klog/v2 v2.4.0/go.mod h1:Od+F08eJP+W3HUb4pSrPpgp9DGU4GzlpG/TmITuYh/Y=
|
||||||
|
@@ -378,7 +378,7 @@ const (
|
|||||||
|
|
||||||
// NewDebuggingRoundTripper allows to display in the logs output debug information
|
// NewDebuggingRoundTripper allows to display in the logs output debug information
|
||||||
// on the API requests performed by the client.
|
// on the API requests performed by the client.
|
||||||
func NewDebuggingRoundTripper(rt http.RoundTripper, levels ...DebugLevel) *debuggingRoundTripper {
|
func NewDebuggingRoundTripper(rt http.RoundTripper, levels ...DebugLevel) http.RoundTripper {
|
||||||
drt := &debuggingRoundTripper{
|
drt := &debuggingRoundTripper{
|
||||||
delegatedRoundTripper: rt,
|
delegatedRoundTripper: rt,
|
||||||
levels: make(map[DebugLevel]bool, len(levels)),
|
levels: make(map[DebugLevel]bool, len(levels)),
|
||||||
|
@@ -419,7 +419,7 @@ func TestHeaderEscapeRoundTrip(t *testing.T) {
|
|||||||
func TestDebuggingRoundTripper(t *testing.T) {
|
func TestDebuggingRoundTripper(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
rawUrl := "https://127.0.0.1:12345/api/v1/pods?limit=500"
|
rawURL := "https://127.0.0.1:12345/api/v1/pods?limit=500"
|
||||||
req := &http.Request{
|
req := &http.Request{
|
||||||
Method: http.MethodGet,
|
Method: http.MethodGet,
|
||||||
Header: map[string][]string{
|
Header: map[string][]string{
|
||||||
@@ -440,7 +440,7 @@ func TestDebuggingRoundTripper(t *testing.T) {
|
|||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
levels: []DebugLevel{DebugJustURL},
|
levels: []DebugLevel{DebugJustURL},
|
||||||
expectedOutputLines: []string{fmt.Sprintf("%s %s", req.Method, rawUrl)},
|
expectedOutputLines: []string{fmt.Sprintf("%s %s", req.Method, rawURL)},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
levels: []DebugLevel{DebugRequestHeaders},
|
levels: []DebugLevel{DebugRequestHeaders},
|
||||||
@@ -471,7 +471,7 @@ func TestDebuggingRoundTripper(t *testing.T) {
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
levels: []DebugLevel{DebugURLTiming},
|
levels: []DebugLevel{DebugURLTiming},
|
||||||
expectedOutputLines: []string{fmt.Sprintf("%s %s %s", req.Method, rawUrl, res.Status)},
|
expectedOutputLines: []string{fmt.Sprintf("%s %s %s", req.Method, rawURL, res.Status)},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
levels: []DebugLevel{DebugResponseStatus},
|
levels: []DebugLevel{DebugResponseStatus},
|
||||||
@@ -489,12 +489,12 @@ func TestDebuggingRoundTripper(t *testing.T) {
|
|||||||
klog.SetOutput(tmpWriteBuffer)
|
klog.SetOutput(tmpWriteBuffer)
|
||||||
klog.LogToStderr(false)
|
klog.LogToStderr(false)
|
||||||
|
|
||||||
// parse rawUrl
|
// parse rawURL
|
||||||
parsedUrl, err := url.Parse(rawUrl)
|
parsedURL, err := url.Parse(rawURL)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("url.Parse(%q) returned error: %v", rawUrl, err)
|
t.Fatalf("url.Parse(%q) returned error: %v", rawURL, err)
|
||||||
}
|
}
|
||||||
req.URL = parsedUrl
|
req.URL = parsedURL
|
||||||
|
|
||||||
// execute the round tripper
|
// execute the round tripper
|
||||||
rt := &testRoundTripper{
|
rt := &testRoundTripper{
|
||||||
|
Reference in New Issue
Block a user