github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

controller/volume: simplify sync logic in syncBoundClaim

Browse Source
This commit is contained in:
Xiang Li
2016-07-11 19:36:36 -07:00
parent c12de567cd
commit 67787caeeb
1 changed files with 38 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/controller/volume/persistentvolume/controller.go
View File

@@ -271,22 +271,19 @@ func (ctrl *PersistentVolumeController) syncBoundClaim(claim *api.PersistentVolu
// [Unit test set 3] // [Unit test set 3]
if claim.Spec.VolumeName == "" { if claim.Spec.VolumeName == "" {
// Claim was bound before but not any more. // Claim was bound before but not any more.
if _, err := ctrl.updateClaimPhaseWithEvent(claim, api.ClaimLost, api.EventTypeWarning, "ClaimLost", "Bound claim has lost reference to PersistentVolume. Data on the volume is lost!"); err != nil { _, err := ctrl.updateClaimPhaseWithEvent(claim, api.ClaimLost, api.EventTypeWarning, "ClaimLost", "Bound claim has lost reference to PersistentVolume. Data on the volume is lost!")
return err return err
} }
return nil
}
obj, found, err := ctrl.volumes.store.GetByKey(claim.Spec.VolumeName) obj, found, err := ctrl.volumes.store.GetByKey(claim.Spec.VolumeName)
if err != nil { if err != nil {
return err return err
} }
if !found { if !found {
// Claim is bound to a non-existing volume. // Claim is bound to a non-existing volume.
if _, err = ctrl.updateClaimPhaseWithEvent(claim, api.ClaimLost, api.EventTypeWarning, "ClaimLost", "Bound claim has lost its PersistentVolume. Data on the volume is lost!"); err != nil { _, err = ctrl.updateClaimPhaseWithEvent(claim, api.ClaimLost, api.EventTypeWarning, "ClaimLost", "Bound claim has lost its PersistentVolume. Data on the volume is lost!")
return err return err
} }
return nil
} else {
volume, ok := obj.(*api.PersistentVolume) volume, ok := obj.(*api.PersistentVolume)
if !ok { if !ok {
return fmt.Errorf("Cannot convert object from volume cache to volume %q!?: %+v", claim.Spec.VolumeName, obj) return fmt.Errorf("Cannot convert object from volume cache to volume %q!?: %+v", claim.Spec.VolumeName, obj)
@@ -304,7 +301,8 @@ func (ctrl *PersistentVolumeController) syncBoundClaim(claim *api.PersistentVolu
return err return err
} }
return nil return nil
} else if volume.Spec.ClaimRef.UID == claim.UID { }
if volume.Spec.ClaimRef.UID == claim.UID {
// All is well // All is well
// NOTE: syncPV can handle this so it can be left out. // NOTE: syncPV can handle this so it can be left out.
// NOTE: bind() call here will do nothing in most cases as // NOTE: bind() call here will do nothing in most cases as
@@ -315,16 +313,13 @@ func (ctrl *PersistentVolumeController) syncBoundClaim(claim *api.PersistentVolu
return err return err
} }
return nil return nil
} else { }
// Claim is bound but volume has a different claimant. // Claim is bound but volume has a different claimant.
// Set the claim phase to 'Lost', which is a terminal // Set the claim phase to 'Lost', which is a terminal
// phase. // phase.
if _, err = ctrl.updateClaimPhaseWithEvent(claim, api.ClaimLost, api.EventTypeWarning, "ClaimMisbound", "Two claims are bound to the same volume, this one is bound incorrectly"); err != nil { _, err = ctrl.updateClaimPhaseWithEvent(claim, api.ClaimLost, api.EventTypeWarning, "ClaimMisbound", "Two claims are bound to the same volume, this one is bound incorrectly")
return err return err
}
return nil
}
}
} }
// syncVolume is the main controller method to decide what to do with a volume. // syncVolume is the main controller method to decide what to do with a volume.