Merge pull request #124838 from carlory/kubeadm-cleanup-todo-1

kubeadm: remove outdate todo
This commit is contained in:
Kubernetes Prow Robot
2024-05-14 01:51:11 -07:00
committed by GitHub

View File

@@ -86,7 +86,6 @@ diff:
out: io.Discard, out: io.Discard,
} }
// TODO: Add test cases for empty cfgPath, it should automatically fetch cfg from cluster
testCases := []struct { testCases := []struct {
name string name string
args []string args []string
@@ -95,6 +94,13 @@ diff:
cfgPath string cfgPath string
expectedError bool expectedError bool
}{ }{
{
name: "valid: run diff with empty config path on valid manifest path",
cfgPath: "",
setManifestPath: true,
manifestPath: testUpgradeDiffManifest,
expectedError: false,
},
{ {
name: "valid: run diff on valid manifest path", name: "valid: run diff on valid manifest path",
cfgPath: testUpgradeDiffConfig, cfgPath: testUpgradeDiffConfig,