kubeadm: fix a bug that ImageExists check returns true when the image isn't in the local storage

cmd/kubeadm/app/util/runtime/runtime.go

@@ -229,8 +229,15 @@ func pullImagesInParallelImpl(images []string, ifNotPresent bool,
 func (runtime *CRIRuntime) ImageExists(image string) bool {
 	ctx, cancel := defaultContext()
 	defer cancel()
-	_, err := runtime.impl.ImageStatus(ctx, runtime.imageService, &runtimeapi.ImageSpec{Image: image}, false)
+	resp, err := runtime.impl.ImageStatus(ctx, runtime.imageService, &runtimeapi.ImageSpec{Image: image}, false)
-	return err == nil
+	if err != nil {
+		klog.Warningf("Failed to get image status, image: %q, error: %v", image, err)
+		return false
+	}
+	if resp == nil || resp.Image == nil {
+		return false
+	}
+	return true
 }
 
 // detectCRISocketImpl is separated out only for test purposes, DON'T call it directly, use DetectCRISocket instead

cmd/kubeadm/app/util/runtime/runtime_test.go

@@ -320,6 +320,11 @@ func TestImageExists(t *testing.T) {
 	}{
 		{
 			name: "valid",
+			prepare: func(mock *fakeImpl) {
+				mock.ImageStatusReturns(&v1.ImageStatusResponse{
+					Image: &v1.Image{},
+				}, nil)
+			},
 			expected: true,
 		},
 		{