Use the generic/typed workqueue throughout

This change makes us use the generic workqueue throughout the project in
order to improve type safety and readability of the code.

pkg/controller/deployment/deployment_controller.go

@@ -94,7 +94,7 @@ type DeploymentController struct {
 	podListerSynced cache.InformerSynced
 
 	// Deployments that need to be synced
-	queue workqueue.RateLimitingInterface
+	queue workqueue.TypedRateLimitingInterface[string]
 }
 
 // NewDeploymentController creates a new DeploymentController.
@@ -105,7 +105,12 @@ func NewDeploymentController(ctx context.Context, dInformer appsinformers.Deploy
 		client:           client,
 		eventBroadcaster: eventBroadcaster,
 		eventRecorder:    eventBroadcaster.NewRecorder(scheme.Scheme, v1.EventSource{Component: "deployment-controller"}),
-		queue:            workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "deployment"),
+		queue: workqueue.NewTypedRateLimitingQueueWithConfig(
+			workqueue.DefaultTypedControllerRateLimiter[string](),
+			workqueue.TypedRateLimitingQueueConfig[string]{
+				Name: "deployment",
+			},
+		),
 	}
 	dc.rsControl = controller.RealRSControl{
 		KubeClient: client,
@@ -486,19 +491,19 @@ func (dc *DeploymentController) processNextWorkItem(ctx context.Context) bool {
 	}
 	defer dc.queue.Done(key)
 
-	err := dc.syncHandler(ctx, key.(string))
+	err := dc.syncHandler(ctx, key)
 	dc.handleErr(ctx, err, key)
 
 	return true
 }
 
-func (dc *DeploymentController) handleErr(ctx context.Context, err error, key interface{}) {
+func (dc *DeploymentController) handleErr(ctx context.Context, err error, key string) {
 	logger := klog.FromContext(ctx)
 	if err == nil || errors.HasStatusCause(err, v1.NamespaceTerminatingCause) {
 		dc.queue.Forget(key)
 		return
 	}
-	ns, name, keyErr := cache.SplitMetaNamespaceKey(key.(string))
+	ns, name, keyErr := cache.SplitMetaNamespaceKey(key)
 	if keyErr != nil {
 		logger.Error(err, "Failed to split meta namespace cache key", "cacheKey", key)
 	}

pkg/controller/deployment/deployment_controller_test.go

@@ -716,11 +716,11 @@ func TestAddReplicaSet(t *testing.T) {
 		t.Fatalf("queue.Len() = %v, want %v", got, want)
 	}
 	key, done := dc.queue.Get()
-	if key == nil || done {
+	if key == "" || done {
 		t.Fatalf("failed to enqueue controller for rs %v", rs1.Name)
 	}
 	expectedKey, _ := controller.KeyFunc(d1)
-	if got, want := key.(string), expectedKey; got != want {
+	if got, want := key, expectedKey; got != want {
 		t.Errorf("queue.Get() = %v, want %v", got, want)
 	}
 
@@ -729,11 +729,11 @@ func TestAddReplicaSet(t *testing.T) {
 		t.Fatalf("queue.Len() = %v, want %v", got, want)
 	}
 	key, done = dc.queue.Get()
-	if key == nil || done {
+	if key == "" || done {
 		t.Fatalf("failed to enqueue controller for rs %v", rs2.Name)
 	}
 	expectedKey, _ = controller.KeyFunc(d2)
-	if got, want := key.(string), expectedKey; got != want {
+	if got, want := key, expectedKey; got != want {
 		t.Errorf("queue.Get() = %v, want %v", got, want)
 	}
 }
@@ -801,11 +801,11 @@ func TestUpdateReplicaSet(t *testing.T) {
 		t.Fatalf("queue.Len() = %v, want %v", got, want)
 	}
 	key, done := dc.queue.Get()
-	if key == nil || done {
+	if key == "" || done {
 		t.Fatalf("failed to enqueue controller for rs %v", rs1.Name)
 	}
 	expectedKey, _ := controller.KeyFunc(d1)
-	if got, want := key.(string), expectedKey; got != want {
+	if got, want := key, expectedKey; got != want {
 		t.Errorf("queue.Get() = %v, want %v", got, want)
 	}
 
@@ -817,11 +817,11 @@ func TestUpdateReplicaSet(t *testing.T) {
 		t.Fatalf("queue.Len() = %v, want %v", got, want)
 	}
 	key, done = dc.queue.Get()
-	if key == nil || done {
+	if key == "" || done {
 		t.Fatalf("failed to enqueue controller for rs %v", rs2.Name)
 	}
 	expectedKey, _ = controller.KeyFunc(d2)
-	if got, want := key.(string), expectedKey; got != want {
+	if got, want := key, expectedKey; got != want {
 		t.Errorf("queue.Get() = %v, want %v", got, want)
 	}
 }
@@ -953,11 +953,11 @@ func TestDeleteReplicaSet(t *testing.T) {
 		t.Fatalf("queue.Len() = %v, want %v", got, want)
 	}
 	key, done := dc.queue.Get()
-	if key == nil || done {
+	if key == "" || done {
 		t.Fatalf("failed to enqueue controller for rs %v", rs1.Name)
 	}
 	expectedKey, _ := controller.KeyFunc(d1)
-	if got, want := key.(string), expectedKey; got != want {
+	if got, want := key, expectedKey; got != want {
 		t.Errorf("queue.Get() = %v, want %v", got, want)
 	}
 
@@ -966,11 +966,11 @@ func TestDeleteReplicaSet(t *testing.T) {
 		t.Fatalf("queue.Len() = %v, want %v", got, want)
 	}
 	key, done = dc.queue.Get()
-	if key == nil || done {
+	if key == "" || done {
 		t.Fatalf("failed to enqueue controller for rs %v", rs2.Name)
 	}
 	expectedKey, _ = controller.KeyFunc(d2)
-	if got, want := key.(string), expectedKey; got != want {
+	if got, want := key, expectedKey; got != want {
 		t.Errorf("queue.Get() = %v, want %v", got, want)
 	}
 }

pkg/controller/deployment/progress_test.go

@@ -168,7 +168,12 @@ func TestRequeueStuckDeployment(t *testing.T) {
 	}
 
 	dc := &DeploymentController{
-		queue: workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "doesnt_matter"),
+		queue: workqueue.NewTypedRateLimitingQueueWithConfig(
+			workqueue.DefaultTypedControllerRateLimiter[string](),
+			workqueue.TypedRateLimitingQueueConfig[string]{
+				Name: "doesnt_matter",
+			},
+		),
 	}
 	dc.enqueueDeployment = dc.enqueue