Deprecate scheduling_duration_seconds Summary metric

This commit is contained in:
sunxiaofei03
2019-12-24 19:17:29 +08:00
parent 5e31799701
commit 70b80ae28a
3 changed files with 14 additions and 13 deletions

View File

@@ -28,8 +28,8 @@ import (
const (
// SchedulerSubsystem - subsystem name used by scheduler
SchedulerSubsystem = "scheduler"
// SchedulingLatencyName - scheduler latency metric name
SchedulingLatencyName = "scheduling_duration_seconds"
// DeprecatedSchedulingDurationName - scheduler duration metric name which is deprecated
DeprecatedSchedulingDurationName = "scheduling_duration_seconds"
// DeprecatedSchedulingLatencyName - scheduler latency metric name which is deprecated
DeprecatedSchedulingLatencyName = "scheduling_latency_seconds"
@@ -62,16 +62,17 @@ var (
// PodScheduleFailures counts how many pods could not be scheduled.
PodScheduleFailures = scheduleAttempts.With(metrics.Labels{"result": "unschedulable"})
// PodScheduleErrors counts how many pods could not be scheduled due to a scheduler error.
PodScheduleErrors = scheduleAttempts.With(metrics.Labels{"result": "error"})
SchedulingLatency = metrics.NewSummaryVec(
PodScheduleErrors = scheduleAttempts.With(metrics.Labels{"result": "error"})
DeprecatedSchedulingDuration = metrics.NewSummaryVec(
&metrics.SummaryOpts{
Subsystem: SchedulerSubsystem,
Name: SchedulingLatencyName,
Name: DeprecatedSchedulingDurationName,
Help: "Scheduling latency in seconds split by sub-parts of the scheduling operation",
// Make the sliding window of 5h.
// TODO: The value for this should be based on some SLI definition (long term).
MaxAge: 5 * time.Hour,
StabilityLevel: metrics.ALPHA,
MaxAge: 5 * time.Hour,
StabilityLevel: metrics.ALPHA,
DeprecatedVersion: "1.18.0",
},
[]string{OperationLabel},
)
@@ -303,7 +304,7 @@ var (
metricsList = []metrics.Registerable{
scheduleAttempts,
SchedulingLatency,
DeprecatedSchedulingDuration,
DeprecatedSchedulingLatency,
E2eSchedulingLatency,
DeprecatedE2eSchedulingLatency,
@@ -366,7 +367,7 @@ func UnschedulablePods() metrics.GaugeMetric {
// Reset resets metrics
func Reset() {
SchedulingLatency.Reset()
DeprecatedSchedulingDuration.Reset()
DeprecatedSchedulingLatency.Reset()
}