Add more test cases for SuccessCriteriaMet
Cleanup error messages in the new code Add validation for the Job controller fields
This commit is contained in:
@@ -2262,16 +2262,14 @@ func TestManagedBy_UsingReservedJobFinalizers(t *testing.T) {
|
||||
t.Fatalf("Error %v when marking the %q pod as succeeded", err, klog.KObj(podObj))
|
||||
}
|
||||
|
||||
// Mark the job as finished so that the built-in controller receives the
|
||||
// Trigger termination for the Job so that the built-in controller receives the
|
||||
// UpdateJob event in reaction to each it would remove the pod's finalizer,
|
||||
// if not for the custom managedBy field.
|
||||
jobObj.Status.Conditions = append(jobObj.Status.Conditions, batchv1.JobCondition{
|
||||
Type: batchv1.JobComplete,
|
||||
Type: batchv1.JobSuccessCriteriaMet,
|
||||
Status: v1.ConditionTrue,
|
||||
})
|
||||
jobObj.Status.StartTime = ptr.To(metav1.Now())
|
||||
jobObj.Status.CompletionTime = ptr.To(metav1.Now())
|
||||
|
||||
if jobObj, err = clientSet.BatchV1().Jobs(jobObj.Namespace).UpdateStatus(ctx, jobObj, metav1.UpdateOptions{}); err != nil {
|
||||
t.Fatalf("Error %v when updating the job as finished %v", err, klog.KObj(jobObj))
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user