Merge pull request #123702 from p0lyn0mial/upstream-clean-up-after-123190
storage/cacher: mark the addition of a metric for waitUntilFreshAndBlock as completed
This commit is contained in:
		@@ -1304,7 +1304,6 @@ func (c *Cacher) waitUntilWatchCacheFreshAndForceAllEvents(ctx context.Context,
 | 
				
			|||||||
			c.watchCache.waitingUntilFresh.Add()
 | 
								c.watchCache.waitingUntilFresh.Add()
 | 
				
			||||||
			defer c.watchCache.waitingUntilFresh.Remove()
 | 
								defer c.watchCache.waitingUntilFresh.Remove()
 | 
				
			||||||
		}
 | 
							}
 | 
				
			||||||
		// TODO(p0lyn0mial): add a metric to track the number of times we have failed while waiting
 | 
					 | 
				
			||||||
		err := c.watchCache.waitUntilFreshAndBlock(ctx, requestedWatchRV)
 | 
							err := c.watchCache.waitUntilFreshAndBlock(ctx, requestedWatchRV)
 | 
				
			||||||
		defer c.watchCache.RUnlock()
 | 
							defer c.watchCache.RUnlock()
 | 
				
			||||||
		return err
 | 
							return err
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user