github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

change underscores to dashes to match the command line argument

Browse Source
This commit is contained in:
David Walter
2015-07-29 15:09:04 -05:00
parent d04fce045e
commit 792fc2269b
22 changed files with 60 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/init/systemd/README.md
View File

@@ -29,7 +29,7 @@ Notes
-----
It may seem reasonable to use --option=${OPTION} in the .service file instead of only putting the command line option in the environment file. However this results in the possibility of daemons being called with --option= if the environment file does not define a value. Whereas including the --option string inside the environment file means that nothing will be passed to the daemon. So the daemon default will be used for things unset by the environment files.
While some command line options to the daemons use the default when passed an empty option some cause the daemon to fail to launch. --allow_privileged= (without a value of true/false) will cause the kube-apiserver and kubelet to refuse to launch.
While some command line options to the daemons use the default when passed an empty option some cause the daemon to fail to launch. --allow-privileged= (without a value of true/false) will cause the kube-apiserver and kubelet to refuse to launch.
It also may seem reasonable to just use $DAEMON_ARGS and string all of these into one line in the environment file. While that makes the .service file simple it makes the admin job more difficult to locate and make appropriate changes to the config. This is a tradeoff between having to update the .service file to add new options or having the config files easy for an admin to work with. I choose: "easy for admin most of the time".