github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make the warning about pod name clearer

Browse Source 
Previously this was cut-paste from deployment.  It didn't make much
sense for pod.
This commit is contained in:
Tim Hockin 2022-12-25 14:16:44 -08:00
parent d2504c94a0
commit 7c7d79b058
No known key found for this signature in database
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/registry/core/pod/strategy.go
View File

@ -114,7 +114,7 @@ func (podStrategy) WarningsOnCreate(ctx context.Context, obj runtime.Object) []s
newPod := obj.(*api.Pod) newPod := obj.(*api.Pod)
var warnings []string var warnings []string
if msgs := utilvalidation.IsDNS1123Label(newPod.Name); len(msgs) != 0 { if msgs := utilvalidation.IsDNS1123Label(newPod.Name); len(msgs) != 0 {
warnings = append(warnings, fmt.Sprintf("metadata.name: this is used in Pod names and hostnames, which can result in surprising behavior; a DNS label is recommended: %v", msgs)) warnings = append(warnings, fmt.Sprintf("metadata.name: this is used in the Pod's hostname, which can result in surprising behavior; a DNS label is recommended: %v", msgs))
} }
warnings = append(warnings, podutil.GetWarningsForPod(ctx, newPod, nil)...) warnings = append(warnings, podutil.GetWarningsForPod(ctx, newPod, nil)...)
return warnings return warnings