Use the pflag StringSlice instead of implementing it ourselves

Saves code and makes our code easier to read because we just use normal
[]string instead of custom type.

pkg/util/list.go

@@ -1,39 +0,0 @@
-/*
-Copyright 2014 The Kubernetes Authors All rights reserved.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package util
-
-import (
-	"fmt"
-	"strings"
-)
-
-type StringList []string
-
-func (sl *StringList) String() string {
-	return fmt.Sprint(*sl)
-}
-
-func (sl *StringList) Set(value string) error {
-	for _, s := range strings.Split(value, ",") {
-		*sl = append(*sl, s)
-	}
-	return nil
-}
-
-func (*StringList) Type() string {
-	return "stringList"
-}

pkg/util/list_test.go

@@ -1,32 +0,0 @@
-/*
-Copyright 2014 The Kubernetes Authors All rights reserved.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package util
-
-import (
-	"reflect"
-	"testing"
-)
-
-func TestStringListSet(t *testing.T) {
-	var sl StringList
-	sl.Set("foo,bar")
-	sl.Set("hop")
-	expected := []string{"foo", "bar", "hop"}
-	if reflect.DeepEqual(expected, []string(sl)) == false {
-		t.Errorf("expected: %v, got: %v:", expected, sl)
-	}
-}