github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #120313 from dairlair/patch-1

Browse Source 
Refactor checkErr func
This commit is contained in:
Kubernetes Prow Robot
2023-08-31 22:02:42 -07:00
committed by GitHub
parent ff5fc28ff3 3c5a58c5f8
commit 83f2d89dc9
1 changed files with 14 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
cmd/kubeadm/app/util/error.go
View File

@@ -73,28 +73,25 @@ type preflightError interface {
// checkErr formats a given error as a string and calls the passed handleErr // checkErr formats a given error as a string and calls the passed handleErr
// func with that string and an exit code. // func with that string and an exit code.
func checkErr(err error, handleErr func(string, int)) { func checkErr(err error, handleErr func(string, int)) {
if err == nil {
return
}
var msg string msg := fmt.Sprintf("%s\nTo see the stack trace of this error execute with --v=5 or higher", err.Error())
if err != nil { // check if the verbosity level in klog is high enough and print a stack trace.
msg = fmt.Sprintf("%s\nTo see the stack trace of this error execute with --v=5 or higher", err.Error()) f := flag.CommandLine.Lookup("v")
// check if the verbosity level in klog is high enough and print a stack trace. if f != nil {
f := flag.CommandLine.Lookup("v") // assume that the "v" flag contains a parseable Int32 as per klog's "Level" type alias,
if f != nil { // thus no error from ParseInt is handled here.
// assume that the "v" flag contains a parseable Int32 as per klog's "Level" type alias, if v, e := strconv.ParseInt(f.Value.String(), 10, 32); e == nil {
// thus no error from ParseInt is handled here. // https://git.k8s.io/community/contributors/devel/sig-instrumentation/logging.md
if v, e := strconv.ParseInt(f.Value.String(), 10, 32); e == nil { // klog.V(5) - Trace level verbosity
// https://git.k8s.io/community/contributors/devel/sig-instrumentation/logging.md if v > 4 {
// klog.V(5) - Trace level verbosity msg = fmt.Sprintf("%+v", err)
if v > 4 {
msg = fmt.Sprintf("%+v", err)
}
} }
} }
} }
if err == nil {
return
}
switch { switch {
case err == ErrExit: case err == ErrExit:
handleErr("", DefaultErrorExitCode) handleErr("", DefaultErrorExitCode)