diff --git a/pkg/kubelet/config/common.go b/pkg/kubelet/config/common.go index 93957d2b82e..cd4b62d98d6 100644 --- a/pkg/kubelet/config/common.go +++ b/pkg/kubelet/config/common.go @@ -93,7 +93,7 @@ func getSelfLink(name, namespace string) string { if len(namespace) == 0 { namespace = metav1.NamespaceDefault } - selfLink = fmt.Sprintf("/api/"+api.Registry.GroupOrDie(api.GroupName).GroupVersion.Version+"/pods/namespaces/%s/%s", name, namespace) + selfLink = fmt.Sprintf("/api/"+api.Registry.GroupOrDie(api.GroupName).GroupVersion.Version+"/namespaces/%s/pods/%s", namespace, name) return selfLink } diff --git a/pkg/kubelet/config/common_test.go b/pkg/kubelet/config/common_test.go index 47774f91b7a..589f79a215d 100644 --- a/pkg/kubelet/config/common_test.go +++ b/pkg/kubelet/config/common_test.go @@ -160,3 +160,31 @@ func TestDecodePodList(t *testing.T) { } } } + +func TestGetSelfLink(t *testing.T) { + var testCases = []struct { + desc string + name string + namespace string + expectedSelfLink string + }{ + { + desc: "No namespace specified", + name: "foo", + namespace: "", + expectedSelfLink: "/api/v1/namespaces/default/pods/foo", + }, + { + desc: "Namespace specified", + name: "foo", + namespace: "bar", + expectedSelfLink: "/api/v1/namespaces/bar/pods/foo", + }, + } + for _, testCase := range testCases { + selfLink := getSelfLink(testCase.name, testCase.namespace) + if testCase.expectedSelfLink != selfLink { + t.Errorf("%s: getSelfLink error, expected: %s, got: %s", testCase.desc, testCase.expectedSelfLink, selfLink) + } + } +}