github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove an old TODO.

Browse Source
This commit is contained in:
Brendan Burns
2018-06-08 21:10:24 -07:00
parent a7a081b541
commit 84dd19eb23
2 changed files with 22 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/kubectl/run.go
View File

@@ -877,8 +877,6 @@ func (BasicPod) Generate(genericParams map[string]interface{}) (runtime.Object,
if len(restartPolicy) == 0 {
restartPolicy = v1.RestartPolicyAlways
}
// TODO: Figure out why we set ImagePullPolicy here, whether we can make it
// consistent with the other places imagePullPolicy is set using flag.
pod := v1.Pod{
ObjectMeta: metav1.ObjectMeta{
Name: name,
@@ -890,7 +888,6 @@ func (BasicPod) Generate(genericParams map[string]interface{}) (runtime.Object,
{
Name: name,
Image: params["image"],
ImagePullPolicy: v1.PullIfNotPresent,
Stdin: stdin,
StdinOnce: !leaveStdinOpen && stdin,
TTY: tty,

6
pkg/kubectl/run_test.go
View File

@@ -426,7 +426,6 @@ func TestGeneratePod(t *testing.T) {
{
Name: "foo",
Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
},
},
DNSPolicy: v1.DNSClusterFirst,
@@ -495,7 +494,6 @@ func TestGeneratePod(t *testing.T) {
{
Name: "foo",
Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
Ports: []v1.ContainerPort{
{
ContainerPort: 80,
@@ -525,7 +523,6 @@ func TestGeneratePod(t *testing.T) {
{
Name: "foo",
Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
Ports: []v1.ContainerPort{
{
ContainerPort: 80,
@@ -565,7 +562,6 @@ func TestGeneratePod(t *testing.T) {
{
Name: "foo",
Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
},
},
DNSPolicy: v1.DNSClusterFirst,
@@ -591,7 +587,6 @@ func TestGeneratePod(t *testing.T) {
{
Name: "foo",
Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
Stdin: true,
StdinOnce: true,
},
@@ -620,7 +615,6 @@ func TestGeneratePod(t *testing.T) {
{
Name: "foo",
Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
Stdin: true,
StdinOnce: false,
},