CollisionCount should have type int32 across controllers that use it for collision avoidance
This commit is contained in:
@@ -453,23 +453,26 @@ func int64P(num int64) *int64 {
|
||||
}
|
||||
|
||||
func TestComputeHash(t *testing.T) {
|
||||
collisionCount := int32(1)
|
||||
otherCollisionCount := int32(2)
|
||||
maxCollisionCount := int32(math.MaxInt32)
|
||||
tests := []struct {
|
||||
name string
|
||||
template *v1.PodTemplateSpec
|
||||
collisionCount *int64
|
||||
otherCollisionCount *int64
|
||||
collisionCount *int32
|
||||
otherCollisionCount *int32
|
||||
}{
|
||||
{
|
||||
name: "simple",
|
||||
template: &v1.PodTemplateSpec{},
|
||||
collisionCount: int64P(1),
|
||||
otherCollisionCount: int64P(2),
|
||||
collisionCount: &collisionCount,
|
||||
otherCollisionCount: &otherCollisionCount,
|
||||
},
|
||||
{
|
||||
name: "using math.MaxInt64",
|
||||
template: &v1.PodTemplateSpec{},
|
||||
collisionCount: nil,
|
||||
otherCollisionCount: int64P(int64(math.MaxInt64)),
|
||||
otherCollisionCount: &maxCollisionCount,
|
||||
},
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user