github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #103252 from pacoxu/defer-fix

Browse Source 
custom-metrics: do cleanup even if the creation is not full succeed
This commit is contained in:
Kubernetes Prow Robot
2022-01-06 12:50:00 -08:00
committed by GitHub
parent 09fccc3533 be27d71eeb
commit 858895da81
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/e2e/autoscaling/custom_metrics_stackdriver_autoscaling.go
View File

@@ -264,10 +264,10 @@ func (tc *CustomMetricTestCase) Run() {
defer monitoring.CleanupDescriptors(gcmService, projectID) defer monitoring.CleanupDescriptors(gcmService, projectID)
err = monitoring.CreateAdapter(monitoring.AdapterDefault) err = monitoring.CreateAdapter(monitoring.AdapterDefault)
defer monitoring.CleanupAdapter(monitoring.AdapterDefault)
if err != nil { if err != nil {
framework.Failf("Failed to set up: %v", err) framework.Failf("Failed to set up: %v", err)
} }
defer monitoring.CleanupAdapter(monitoring.AdapterDefault)
// Run application that exports the metric // Run application that exports the metric
err = createDeploymentToScale(tc.framework, tc.kubeClient, tc.deployment, tc.pod) err = createDeploymentToScale(tc.framework, tc.kubeClient, tc.deployment, tc.pod)