Fix golint failures in some pkg/kubelet packages

Fixed:
- pkg/kubelet/pod
- pkg/kubelet/metrics
- pkg/kubelet/configmap
- pkg/kubelet/config
This commit is contained in:
obitech
2019-03-12 22:35:57 +01:00
parent cc270c138d
commit 898c40a484
12 changed files with 96 additions and 30 deletions

View File

@@ -16,7 +16,6 @@ See the License for the specific language governing permissions and
limitations under the License.
*/
// Reads the pod configuration from file or a directory of files.
package config
import (
@@ -50,17 +49,17 @@ func (e *retryableError) Error() string {
func (s *sourceFile) startWatch() {
backOff := flowcontrol.NewBackOff(retryPeriod, maxRetryPeriod)
backOffId := "watch"
backOffID := "watch"
go wait.Forever(func() {
if backOff.IsInBackOffSinceUpdate(backOffId, time.Now()) {
if backOff.IsInBackOffSinceUpdate(backOffID, time.Now()) {
return
}
if err := s.doWatch(); err != nil {
klog.Errorf("Unable to read config path %q: %v", s.path, err)
if _, retryable := err.(*retryableError); !retryable {
backOff.Next(backOffId, time.Now())
backOff.Next(backOffID, time.Now())
}
}
}, retryPeriod)
@@ -132,9 +131,8 @@ func (s *sourceFile) consumeWatchEvent(e *watchEvent) error {
case podAdd, podModify:
if pod, err := s.extractFromFile(e.fileName); err != nil {
return fmt.Errorf("can't process config file %q: %v", e.fileName, err)
} else {
return s.store.Add(pod)
}
return s.store.Add(pod)
case podDelete:
if objKey, keyExist := s.fileKeyMapping[e.fileName]; keyExist {
pod, podExist, err := s.store.GetByKey(objKey)
@@ -145,9 +143,8 @@ func (s *sourceFile) consumeWatchEvent(e *watchEvent) error {
} else {
if err = s.store.Delete(pod); err != nil {
return fmt.Errorf("failed to remove deleted pod from cache: %v", err)
} else {
delete(s.fileKeyMapping, e.fileName)
}
delete(s.fileKeyMapping, e.fileName)
}
}
}