github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix golint failures under e2e/framework/metrics

Browse Source
This commit is contained in:
Kenichi Omichi
2019-02-13 01:46:04 +00:00
parent dbe669aeb1
commit 89f6f1d0cc
12 changed files with 86 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/e2e/framework/metrics/api_server_metrics.go
View File

@@ -16,26 +16,28 @@ limitations under the License.
package metrics
type ApiServerMetrics Metrics
// APIServerMetrics is metrics for API server
type APIServerMetrics Metrics
func (m *ApiServerMetrics) Equal(o ApiServerMetrics) bool {
// Equal returns true if all metrics are the same as the arguments.
func (m *APIServerMetrics) Equal(o APIServerMetrics) bool {
return (*Metrics)(m).Equal(Metrics(o))
}
func NewApiServerMetrics() ApiServerMetrics {
func newAPIServerMetrics() APIServerMetrics {
result := NewMetrics()
return ApiServerMetrics(result)
return APIServerMetrics(result)
}
func parseApiServerMetrics(data string) (ApiServerMetrics, error) {
result := NewApiServerMetrics()
func parseAPIServerMetrics(data string) (APIServerMetrics, error) {
result := newAPIServerMetrics()
if err := parseMetrics(data, (*Metrics)(&result)); err != nil {
return ApiServerMetrics{}, err
return APIServerMetrics{}, err
}
return result, nil
}
func (g *MetricsGrabber) getMetricsFromApiServer() (string, error) {
func (g *Grabber) getMetricsFromAPIServer() (string, error) {
rawOutput, err := g.client.CoreV1().RESTClient().Get().RequestURI("/metrics").Do().Raw()
if err != nil {
return "", err