github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move output and url checks under raw flag condition

Browse Source
This commit is contained in:
Zhenguo Niu
2017-12-19 17:51:30 +08:00
parent a0a69a3583
commit 8a7f8bc046
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/kubectl/cmd/resource/get.go
View File

@@ -212,14 +212,16 @@ func (options *GetOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args
// Validate checks the set of flags provided by the user. // Validate checks the set of flags provided by the user.
func (options *GetOptions) Validate(cmd *cobra.Command) error { func (options *GetOptions) Validate(cmd *cobra.Command) error {
if len(options.Raw) > 0 && (options.Watch || options.WatchOnly || len(options.LabelSelector) > 0 || options.Export) { if len(options.Raw) > 0 {
return fmt.Errorf("--raw may not be specified with other flags that filter the server request or alter the output") if options.Watch || options.WatchOnly || len(options.LabelSelector) > 0 || options.Export {
} return fmt.Errorf("--raw may not be specified with other flags that filter the server request or alter the output")
if len(cmdutil.GetFlagString(cmd, "output")) > 0 { }
return cmdutil.UsageErrorf(cmd, "--raw and --output are mutually exclusive") if len(cmdutil.GetFlagString(cmd, "output")) > 0 {
} return cmdutil.UsageErrorf(cmd, "--raw and --output are mutually exclusive")
if _, err := url.ParseRequestURI(options.Raw); err != nil { }
return cmdutil.UsageErrorf(cmd, "--raw must be a valid URL path: %v", err) if _, err := url.ParseRequestURI(options.Raw); err != nil {
return cmdutil.UsageErrorf(cmd, "--raw must be a valid URL path: %v", err)
}
} }
if cmdutil.GetFlagBool(cmd, "show-labels") { if cmdutil.GetFlagBool(cmd, "show-labels") {
outputOption := cmd.Flags().Lookup("output").Value.String() outputOption := cmd.Flags().Lookup("output").Value.String()