github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #112475 from vatsalparekh/fix-TestRESTClientLimiter

Browse Source 
Fix Infelicities in TestRESTClientLimiter
This commit is contained in:
Kubernetes Prow Robot
2022-09-15 17:53:34 -07:00
committed by GitHub
parent 369d0cfced c980cf489e
commit 8b7840e393
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/client-go/rest/config_test.go
View File

@@ -163,18 +163,22 @@ func TestRESTClientLimiter(t *testing.T) {
Limiter flowcontrol.RateLimiter Limiter flowcontrol.RateLimiter
}{ }{
{ {
Name: "with no QPS",
Config: Config{}, Config: Config{},
Limiter: flowcontrol.NewTokenBucketRateLimiter(5, 10), Limiter: flowcontrol.NewTokenBucketRateLimiter(5, 10),
}, },
{ {
Name: "with QPS:10",
Config: Config{QPS: 10}, Config: Config{QPS: 10},
Limiter: flowcontrol.NewTokenBucketRateLimiter(10, 10), Limiter: flowcontrol.NewTokenBucketRateLimiter(10, 10),
}, },
{ {
Name: "with QPS:-1",
Config: Config{QPS: -1}, Config: Config{QPS: -1},
Limiter: nil, Limiter: nil,
}, },
{ {
Name: "with RateLimiter",
Config: Config{ Config: Config{
RateLimiter: flowcontrol.NewTokenBucketRateLimiter(11, 12), RateLimiter: flowcontrol.NewTokenBucketRateLimiter(11, 12),
}, },
@@ -191,7 +195,7 @@ func TestRESTClientLimiter(t *testing.T) {
t.Fatalf("unexpected error: %v", err) t.Fatalf("unexpected error: %v", err)
} }
if !reflect.DeepEqual(testCase.Limiter, client.rateLimiter) { if !reflect.DeepEqual(testCase.Limiter, client.rateLimiter) {
t.Fatalf("unexpected rate limiter: %#v", client.rateLimiter) t.Fatalf("unexpected rate limiter: %#v, expected %#v at %s", client.rateLimiter, testCase.Limiter, testCase.Name)
} }
}) })
t.Run("Unversioned_"+testCase.Name, func(t *testing.T) { t.Run("Unversioned_"+testCase.Name, func(t *testing.T) {
@@ -203,7 +207,7 @@ func TestRESTClientLimiter(t *testing.T) {
t.Fatalf("unexpected error: %v", err) t.Fatalf("unexpected error: %v", err)
} }
if !reflect.DeepEqual(testCase.Limiter, client.rateLimiter) { if !reflect.DeepEqual(testCase.Limiter, client.rateLimiter) {
t.Fatalf("unexpected rate limiter: %#v", client.rateLimiter) t.Fatalf("unexpected rate limiter: %#v, expected %#v at %s", client.rateLimiter, testCase.Limiter, testCase.Name)
} }
}) })
} }