github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pass mbforbes TODOs to others.

Browse Source
This commit is contained in:
Max Forbes
2015-08-26 10:05:34 -07:00
parent 14193b45e3
commit 8ca0654f94
9 changed files with 26 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/e2e/cluster_upgrade.go
View File

@@ -133,7 +133,7 @@ func masterUpgradeGKE(v string) error {
}
var masterPush = func(_ string) error {
// TODO(mbforbes): Make master push use the provided version.
// TODO(mikedanese): Make master push use the provided version.
_, _, err := runCmd(path.Join(testContext.RepoRoot, "hack/e2e-internal/e2e-push.sh"), "-m")
return err
}
@@ -233,7 +233,7 @@ var _ = Describe("Skipped", func() {
}
testLoadBalancerReachable(ingress, 80)
// TODO(mbforbes): Add setup, validate, and teardown for:
// TODO(mikedanese): Add setup, validate, and teardown for:
// - secrets
// - volumes
// - persistent volumes
@@ -485,7 +485,7 @@ func validate(f Framework, svcNameWant, rcNameWant string, ingress api.LoadBalan
if svcNameWant != svc.Name {
return fmt.Errorf("wanted service name %q, got %q", svcNameWant, svc.Name)
}
// TODO(mbforbes): Make testLoadBalancerReachable return an error.
// TODO(mikedanese): Make testLoadBalancerReachable return an error.
testLoadBalancerReachable(ingress, 80)
Logf("Cluster validation succeeded")
@@ -517,7 +517,7 @@ func migTemplate() (string, error) {
var templ string
key := "instanceTemplate"
if wait.Poll(poll, singleCallTimeout, func() (bool, error) {
// TODO(mbforbes): make this hit the compute API directly instead of
// TODO(mikedanese): make this hit the compute API directly instead of
// shelling out to gcloud.
// An `instance-groups managed describe` call outputs what we want to stdout.
output, _, err := retryCmd("gcloud", "compute", "instance-groups", "managed",
@@ -555,9 +555,9 @@ func migRollingUpdateStart(templ string, nt time.Duration) (string, error) {
var id string
prefix, suffix := "Started [", "]."
if err := wait.Poll(poll, singleCallTimeout, func() (bool, error) {
// TODO(mbforbes): make this hit the compute API directly instead of
// TODO(mikedanese): make this hit the compute API directly instead of
// shelling out to gcloud.
// NOTE(mbforbes): If you are changing this gcloud command, update
// NOTE(mikedanese): If you are changing this gcloud command, update
// cluster/gce/upgrade.sh to match this EXACTLY.
// A `rolling-updates start` call outputs what we want to stderr.
_, output, err := retryCmd("gcloud", append(migUdpateCmdBase(),
@@ -610,7 +610,7 @@ func migRollingUpdateStart(templ string, nt time.Duration) (string, error) {
//
// {"alpha", "compute"}
//
// TODO(mbforbes): Remove this hack on July 29, 2015 when the migration to
// TODO(mikedanese): Remove this hack on July 29, 2015 when the migration to
// `gcloud alpha compute rolling-updates` is complete.
func migUdpateCmdBase() []string {
b := []string{"preview"}

2
test/e2e/reboot.go
View File

@@ -112,7 +112,7 @@ func testReboot(c *client.Client, rebootCmd string) {
// Wait for all to finish and check the final result.
failed := false
// TODO(mbforbes): Change to `for range` syntax and remove logging once
// TODO(a-robinson): Change to `for range` syntax and remove logging once
// we support only Go >= 1.4.
for _, n := range nodelist.Items {
if !<-result {

2
test/e2e/restart.go
View File

@@ -221,7 +221,7 @@ func restartNodes(provider string, nt time.Duration) error {
}
}
// TODO(mbforbes): Switch this to MIG recreate-instances. This can be done
// TODO(marekbiskup): Switch this to MIG recreate-instances. This can be done
// with the following bash, but needs to be written in Go:
//
// # Step 1: Get instance names.

2
test/e2e/service.go
View File

@@ -1533,7 +1533,7 @@ func (t *WebserverTest) Cleanup() []error {
if _, err := t.Client.ReplicationControllers(t.Namespace).Update(old); err != nil {
errs = append(errs, err)
}
// TODO(mbforbes): Wait.
// TODO(mikedanese): Wait.
// Then, delete the RC altogether.
if err := t.Client.ReplicationControllers(t.Namespace).Delete(rcName); err != nil {

4
test/e2e/util.go
View File

@@ -1585,7 +1585,7 @@ func NodeSSHHosts(c *client.Client) ([]string, error) {
for _, addr := range n.Status.Addresses {
// Use the first external IP address we find on the node, and
// use at most one per node.
// TODO(mbforbes): Use the "preferred" address for the node, once
// TODO(roberthbailey): Use the "preferred" address for the node, once
// such a thing is defined (#2462).
if addr.Type == api.NodeExternalIP {
hosts = append(hosts, addr.Address+":22")
@@ -1680,7 +1680,7 @@ func checkPodsRunningReady(c *client.Client, ns string, podNames []string, timeo
}
// Wait for them all to finish.
success := true
// TODO(mbforbes): Change to `for range` syntax and remove logging once we
// TODO(a-robinson): Change to `for range` syntax and remove logging once we
// support only Go >= 1.4.
for _, podName := range podNames {
if !<-result {