e2e/storage: decentralized settings
Tests shouldn't have to use the central context for their settings,
because conceptually tests and framework get developed independently.
This does not yet use the new framework/config utility code because
that code still needs to be reviewed.
Besides moving the flags, they also get renamed from the top-level
"--csiImage{Version|Registry}" to
"--storage.csi.image.{version|registry}". These flags were introduced
fairly recently and shouldn't be in use much, so now is a good time to
introduce a hierarchical naming for storage flags, in particular
because more flags will be added soon.
This commit is contained in:
@@ -20,6 +20,7 @@ limitations under the License.
|
||||
package storage
|
||||
|
||||
import (
|
||||
"flag"
|
||||
"fmt"
|
||||
"io/ioutil"
|
||||
"os"
|
||||
@@ -46,18 +47,22 @@ import (
|
||||
csicrd "k8s.io/csi-api/pkg/crd"
|
||||
)
|
||||
|
||||
var csiImageVersions = map[string]string{
|
||||
"hostpathplugin": "v0.4.0",
|
||||
"csi-attacher": "v0.4.0",
|
||||
"csi-provisioner": "v0.4.0",
|
||||
"driver-registrar": "v0.4.0",
|
||||
}
|
||||
var (
|
||||
csiImageVersion = flag.String("storage.csi.image.version", "", "overrides the default tag used for hostpathplugin/csi-attacher/csi-provisioner/driver-registrar images")
|
||||
csiImageRegistry = flag.String("storage.csi.image.registry", "quay.io/k8scsi", "overrides the default repository used for hostpathplugin/csi-attacher/csi-provisioner/driver-registrar images")
|
||||
csiImageVersions = map[string]string{
|
||||
"hostpathplugin": "v0.4.0",
|
||||
"csi-attacher": "v0.4.0",
|
||||
"csi-provisioner": "v0.4.0",
|
||||
"driver-registrar": "v0.4.0",
|
||||
}
|
||||
)
|
||||
|
||||
func csiContainerImage(image string) string {
|
||||
var fullName string
|
||||
fullName += framework.TestContext.CSIImageRegistry + "/" + image + ":"
|
||||
if framework.TestContext.CSIImageVersion != "" {
|
||||
fullName += framework.TestContext.CSIImageVersion
|
||||
fullName += *csiImageRegistry + "/" + image + ":"
|
||||
if *csiImageVersion != "" {
|
||||
fullName += *csiImageVersion
|
||||
} else {
|
||||
fullName += csiImageVersions[image]
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user