Properly close test http servers in unversioned

If not, using `go test -count=n` would make them pile up and ultimately
get to the limit of open files:

	client_test.go:522: expected an error, got Get http://127.0.0.1:46070/api: dial tcp 127.0.0.1:46070: socket: too many open files

Steps to reproduce (no longer fails):

	godep go test -short -run '^$' -o test .
	./test -test.run '^TestGetSwaggerSchema' -test.count 100

Note that this might not fail if your `ulimit -n` is not low enough.
This commit is contained in:
Daniel Martí
2015-12-05 13:49:36 +01:00
parent 5505706891
commit 91fbff99dc
21 changed files with 137 additions and 2 deletions

View File

@@ -60,6 +60,7 @@ func TestListControllers(t *testing.T) {
},
}
receivedControllerList, err := c.Setup(t).ReplicationControllers(ns).List(api.ListOptions{})
defer c.Close()
c.Validate(t, receivedControllerList, err)
}
@@ -86,6 +87,7 @@ func TestGetController(t *testing.T) {
},
}
receivedController, err := c.Setup(t).ReplicationControllers(ns).Get("foo")
defer c.Close()
c.Validate(t, receivedController, err)
}
@@ -93,6 +95,7 @@ func TestGetControllerWithNoName(t *testing.T) {
ns := api.NamespaceDefault
c := &simple.Client{Error: true}
receivedPod, err := c.Setup(t).ReplicationControllers(ns).Get("")
defer c.Close()
if (err != nil) && (err.Error() != simple.NameRequiredError) {
t.Errorf("Expected error: %v, but got %v", simple.NameRequiredError, err)
}
@@ -125,6 +128,7 @@ func TestUpdateController(t *testing.T) {
},
}
receivedController, err := c.Setup(t).ReplicationControllers(ns).Update(requestController)
defer c.Close()
c.Validate(t, receivedController, err)
}
@@ -156,6 +160,7 @@ func TestUpdateStatusController(t *testing.T) {
},
}
receivedController, err := c.Setup(t).ReplicationControllers(ns).UpdateStatus(requestController)
defer c.Close()
c.Validate(t, receivedController, err)
}
func TestDeleteController(t *testing.T) {
@@ -165,6 +170,7 @@ func TestDeleteController(t *testing.T) {
Response: simple.Response{StatusCode: 200},
}
err := c.Setup(t).ReplicationControllers(ns).Delete("foo")
defer c.Close()
c.Validate(t, nil, err)
}
@@ -193,5 +199,6 @@ func TestCreateController(t *testing.T) {
},
}
receivedController, err := c.Setup(t).ReplicationControllers(ns).Create(requestController)
defer c.Close()
c.Validate(t, receivedController, err)
}