github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #125755 from saschagrunert/named-param-service

Browse Source 
Make CRI service interface function arguments consistent
This commit is contained in:
Kubernetes Prow Robot
2024-06-27 04:22:05 -07:00
committed by GitHub
parent 24478e0c4a 4411a070fc
commit 95c7621ed0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/cri-api/pkg/apis/services.go
View File

@@ -51,7 +51,7 @@ type ContainerManager interface {
// If command exits with a non-zero exit code, an error is returned.
ExecSync(ctx context.Context, containerID string, cmd []string, timeout time.Duration) (stdout []byte, stderr []byte, err error)
// Exec prepares a streaming endpoint to execute a command in the container, and returns the address.
Exec(context.Context, *runtimeapi.ExecRequest) (*runtimeapi.ExecResponse, error)
Exec(ctx context.Context, request *runtimeapi.ExecRequest) (*runtimeapi.ExecResponse, error)
// Attach prepares a streaming endpoint to attach to a running container, and returns the address.
Attach(ctx context.Context, req *runtimeapi.AttachRequest) (*runtimeapi.AttachResponse, error)
// ReopenContainerLog asks runtime to reopen the stdout/stderr log file
@@ -81,7 +81,7 @@ type PodSandboxManager interface {
// ListPodSandbox returns a list of Sandbox.
ListPodSandbox(ctx context.Context, filter *runtimeapi.PodSandboxFilter) ([]*runtimeapi.PodSandbox, error)
// PortForward prepares a streaming endpoint to forward ports from a PodSandbox, and returns the address.
PortForward(context.Context, *runtimeapi.PortForwardRequest) (*runtimeapi.PortForwardResponse, error)
PortForward(ctx context.Context, request *runtimeapi.PortForwardRequest) (*runtimeapi.PortForwardResponse, error)
}
// ContainerStatsManager contains methods for retrieving the container