diff --git a/pkg/httplog/log_test.go b/pkg/httplog/log_test.go index 57829299e7c..906ec367366 100644 --- a/pkg/httplog/log_test.go +++ b/pkg/httplog/log_test.go @@ -24,6 +24,20 @@ import ( "testing" ) +func TestDefaultStacktracePred(t *testing.T) { + for _, x := range []int{101, 200, 204, 302, 400, 404} { + if DefaultStacktracePred(x) { + t.Fatalf("should not log on %v by default", x) + } + } + + for _, x := range []int{500, 100} { + if !DefaultStacktracePred(x) { + t.Fatalf("should log on %v by default", x) + } + } +} + func TestHandler(t *testing.T) { want := &httptest.ResponseRecorder{ HeaderMap: make(http.Header), diff --git a/pkg/kubelet/server/server.go b/pkg/kubelet/server/server.go index ec609c0d050..ee95a223d78 100644 --- a/pkg/kubelet/server/server.go +++ b/pkg/kubelet/server/server.go @@ -675,6 +675,7 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, req *http.Request) { defer httplog.NewLogged(req, &w).StacktraceWhen( httplog.StatusIsNot( http.StatusOK, + http.StatusFound, http.StatusMovedPermanently, http.StatusTemporaryRedirect, http.StatusBadRequest,