github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #70039 from liggitt/deployment-rollback

Browse Source 
Switch kubectl rollout to directly rolling back deployments
This commit is contained in:
k8s-ci-robot
2018-10-29 18:52:51 -07:00
committed by GitHub
parent d265e7eeff 57df11bc0f
commit 975e6c0a73
6 changed files with 145 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/cmd/apps.sh
View File

@@ -299,7 +299,7 @@ run_deployment_tests() {
sleep 1
kube::test::get_object_assert deployment "{{range.items}}{{$image_field0}}:{{end}}" "${IMAGE_DEPLOYMENT_R1}:"
# Rollback to revision 1000000 - should be no-op
kubectl rollout undo deployment nginx --to-revision=1000000 "${kube_flags[@]}"
! kubectl rollout undo deployment nginx --to-revision=1000000 "${kube_flags[@]}"
kube::test::get_object_assert deployment "{{range.items}}{{$image_field0}}:{{end}}" "${IMAGE_DEPLOYMENT_R1}:"
# Rollback to last revision
kubectl rollout undo deployment nginx "${kube_flags[@]}"

2
test/cmd/template-output.sh
View File

@@ -222,7 +222,7 @@ EOF
kube::test::if_has_string "${output_message}" 'deploy:'
# check that "rollout undo" supports --template output
output_message=$(kubectl "${kube_flags[@]}" rollout undo deploy/deploy --template="{{ .metadata.name }}:")
output_message=$(kubectl "${kube_flags[@]}" rollout undo deploy/deploy --to-revision=1 --template="{{ .metadata.name }}:")
kube::test::if_has_string "${output_message}" 'deploy:'
# check that "config view" command supports --template output