fix test test should assign default SC to PVCs that have no SC set failure
This commit is contained in:
@@ -136,11 +136,11 @@ func temporarilyUnsetDefaultClasses(ctx context.Context, client clientset.Interf
|
|||||||
classes, err := client.StorageV1().StorageClasses().List(ctx, metav1.ListOptions{})
|
classes, err := client.StorageV1().StorageClasses().List(ctx, metav1.ListOptions{})
|
||||||
framework.ExpectNoError(err)
|
framework.ExpectNoError(err)
|
||||||
|
|
||||||
var changedClasses []storagev1.StorageClass
|
changedClasses := make(map[string]bool)
|
||||||
|
|
||||||
for _, sc := range classes.Items {
|
for _, sc := range classes.Items {
|
||||||
if sc.Annotations[storageutil.IsDefaultStorageClassAnnotation] == "true" {
|
if sc.Annotations[storageutil.IsDefaultStorageClassAnnotation] == "true" {
|
||||||
changedClasses = append(changedClasses, sc)
|
changedClasses[sc.GetName()] = true
|
||||||
sc.Annotations[storageutil.IsDefaultStorageClassAnnotation] = "false"
|
sc.Annotations[storageutil.IsDefaultStorageClassAnnotation] = "false"
|
||||||
_, err := client.StorageV1().StorageClasses().Update(ctx, &sc, metav1.UpdateOptions{})
|
_, err := client.StorageV1().StorageClasses().Update(ctx, &sc, metav1.UpdateOptions{})
|
||||||
framework.ExpectNoError(err)
|
framework.ExpectNoError(err)
|
||||||
@@ -148,12 +148,16 @@ func temporarilyUnsetDefaultClasses(ctx context.Context, client clientset.Interf
|
|||||||
}
|
}
|
||||||
|
|
||||||
return func() {
|
return func() {
|
||||||
for _, sc := range changedClasses {
|
classes, err = client.StorageV1().StorageClasses().List(ctx, metav1.ListOptions{})
|
||||||
|
framework.ExpectNoError(err)
|
||||||
|
for _, sc := range classes.Items {
|
||||||
|
if _, found := changedClasses[sc.GetName()]; found {
|
||||||
sc.Annotations[storageutil.IsDefaultStorageClassAnnotation] = "true"
|
sc.Annotations[storageutil.IsDefaultStorageClassAnnotation] = "true"
|
||||||
_, err := client.StorageV1().StorageClasses().Update(ctx, &sc, metav1.UpdateOptions{})
|
_, err := client.StorageV1().StorageClasses().Update(ctx, &sc, metav1.UpdateOptions{})
|
||||||
framework.ExpectNoError(err)
|
framework.ExpectNoError(err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user