omit the reason if we don't have an error when using rbac

2017-01-04 11:41:43 +08:00
parent f95362f953
commit 9b38eaf98e
2 changed files with 11 additions and 2 deletions
--- a/pkg/genericapiserver/api/handlers/responsewriters/errors.go
+++ b/pkg/genericapiserver/api/handlers/responsewriters/errors.go
@@ -38,7 +38,12 @@ func Forbidden(attributes authorizer.Attributes, w http.ResponseWriter, req *htt
 	w.Header().Set("Content-Type", "text/plain")
 	w.Header().Set("X-Content-Type-Options", "nosniff")
 	w.WriteHeader(http.StatusForbidden)
-	fmt.Fprintf(w, "%s: %q", msg, reason)
+
+	if len(reason) == 0 {
+		fmt.Fprintf(w, "%s", msg)
+	} else {
+		fmt.Fprintf(w, "%s: %q", msg, reason)
+	}
 }

 func forbiddenMessage(attributes authorizer.Attributes) string {