github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Address shell-related comments.

Browse Source
This commit is contained in:
Katharine Berry
2018-08-31 17:07:25 -07:00
parent 13d1961d2b
commit 9b790dab7d
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
hack/lib/golang.sh
View File

@@ -463,7 +463,7 @@ kube::golang::path_for_coverage_dummy_test() {
local package="$1"
local path="${KUBE_GOPATH}/src/${package}"
local name=$(basename "${package}")
echo "$path/zz_autogenerated_${name}_test.go"
echo "$path/zz_generated_${name}_test.go"
}
# Argument: the name of a Kubernetes package (e.g. k8s.io/kubernetes/cmd/kube-scheduler).
@@ -504,8 +504,9 @@ kube::golang::delete_coverage_dummy_test() {
}
# Arguments: a list of kubernetes packages to build.
# Expected variables: build_args should be set to an array of Go build arguments.
# In addition, the standard build globals are assumed.
# Expected variables: ${build_args} should be set to an array of Go build arguments.
# In addition, ${package} and ${platform} should have been set earlier, and if
# ${build_with_coverage} is set, coverage instrumentation will be enabled.
#
# Invokes Go to actually build some packages. If coverage is disabled, simply invokes
# go install. If coverage is enabled, builds covered binaries using go test, temporarily