From 9d19c207d228ad8e22c12d0e1d9e6309a7d6e08c Mon Sep 17 00:00:00 2001 From: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com> Date: Tue, 2 May 2023 21:01:48 +0000 Subject: [PATCH] fix: fixes flake in TestKMSv2Healthz Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com> --- .../controlplane/transformation/transformation_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/integration/controlplane/transformation/transformation_test.go b/test/integration/controlplane/transformation/transformation_test.go index 23d3667b58a..fa623da6d7e 100644 --- a/test/integration/controlplane/transformation/transformation_test.go +++ b/test/integration/controlplane/transformation/transformation_test.go @@ -528,7 +528,7 @@ func (e *transformTest) printMetrics() error { func mustBeHealthy(t kubeapiservertesting.Logger, checkName, wantBodyContains string, clientConfig *rest.Config, excludes ...string) { t.Helper() var restErr error - pollErr := wait.PollImmediate(2*time.Second, 2*time.Minute, func() (bool, error) { + pollErr := wait.PollImmediate(1*time.Second, 5*time.Minute, func() (bool, error) { body, ok, err := getHealthz(checkName, clientConfig, excludes...) restErr = err if err != nil { @@ -541,7 +541,7 @@ func mustBeHealthy(t kubeapiservertesting.Logger, checkName, wantBodyContains st return done, nil }) - if pollErr == wait.ErrWaitTimeout { + if pollErr != nil { t.Fatalf("failed to get the expected healthz status of OK for check: %s, error: %v, debug inner error: %v", checkName, pollErr, restErr) } } @@ -549,7 +549,7 @@ func mustBeHealthy(t kubeapiservertesting.Logger, checkName, wantBodyContains st func mustBeUnHealthy(t kubeapiservertesting.Logger, checkName, wantBodyContains string, clientConfig *rest.Config, excludes ...string) { t.Helper() var restErr error - pollErr := wait.PollImmediate(2*time.Second, 2*time.Minute, func() (bool, error) { + pollErr := wait.PollImmediate(1*time.Second, 5*time.Minute, func() (bool, error) { body, ok, err := getHealthz(checkName, clientConfig, excludes...) restErr = err if err != nil { @@ -562,7 +562,7 @@ func mustBeUnHealthy(t kubeapiservertesting.Logger, checkName, wantBodyContains return done, nil }) - if pollErr == wait.ErrWaitTimeout { + if pollErr != nil { t.Fatalf("failed to get the expected healthz status of !OK for check: %s, error: %v, debug inner error: %v", checkName, pollErr, restErr) } }