github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: do not allow nil Callbacks functions

Browse Source 
If user specifies a nil callback, then error out
rather than crashing at runtime due to a nil reference.
This commit is contained in:
Harry Bagdi
2019-07-29 11:27:28 -07:00
parent 3be827e912
commit 9dbbc652ef
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
staging/src/k8s.io/client-go/tools/leaderelection/leaderelection.go
View File

@@ -89,6 +89,12 @@ func NewLeaderElector(lec LeaderElectionConfig) (*LeaderElector, error) {
if lec.RetryPeriod < 1 { if lec.RetryPeriod < 1 {
return nil, fmt.Errorf("retryPeriod must be greater than zero") return nil, fmt.Errorf("retryPeriod must be greater than zero")
} }
if lec.Callbacks.OnStartedLeading == nil {
return nil, fmt.Errorf("OnStartedLeading callback must not be nil")
}
if lec.Callbacks.OnStoppedLeading == nil {
return nil, fmt.Errorf("OnStoppedLeading callback must not be nil")
}
if lec.Lock == nil { if lec.Lock == nil {
return nil, fmt.Errorf("Lock must not be nil.") return nil, fmt.Errorf("Lock must not be nil.")