Merge pull request #40289 from xilabao/fix-save-config-in-create-subcommand
Automatic merge from submit-queue fix --save-config in create subcommand --save-config option doesn't work. ``` #kubectl create rolebinding a --role=b --user=c --save-config rolebinding "a" created ``` old output: ``` #kubectl get rolebinding a -o yaml apiVersion: rbac.authorization.k8s.io/v1beta1 kind: RoleBinding metadata: creationTimestamp: 2017-01-23T10:09:48Z name: a namespace: default resourceVersion: "281" selfLink: /apis/rbac.authorization.k8s.io/v1beta1/namespaces/default/rolebindings/a uid: 12abccd6-e154-11e6-819c-525400f84377 roleRef: apiGroup: rbac.authorization.k8s.io kind: Role name: b subjects: - apiVersion: rbac/v1alpha1 kind: User name: c ``` expected output: ``` #kubectl get rolebinding a -o yaml apiVersion: rbac.authorization.k8s.io/v1beta1 kind: RoleBinding metadata: annotations: kubectl.kubernetes.io/last-applied-configuration: | {"kind":"RoleBinding","apiVersion":"rbac.authorization.k8s.io/v1beta1","metadata":{"name":"c","creationTimestamp":null},"subjects":[{"kind":"User","apiVersion":"rbac/v1alpha1","name":"c"}],"roleRef":{"apiGroup":"rbac.authorization.k8s.io","kind":"Role","name":"b"}} creationTimestamp: 2017-01-23T10:09:48Z name: a namespace: default resourceVersion: "281" selfLink: /apis/rbac.authorization.k8s.io/v1beta1/namespaces/default/rolebindings/a uid: 12abccd6-e154-11e6-819c-525400f84377 roleRef: apiGroup: rbac.authorization.k8s.io kind: Role name: b subjects: - apiVersion: rbac/v1alpha1 kind: User name: c ```
This commit is contained in:
commit
a2931c6218
@ -251,9 +251,11 @@ func RunCreateSubcommand(f cmdutil.Factory, cmd *cobra.Command, out io.Writer, o
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if err := kubectl.UpdateApplyAnnotation(info, f.JSONEncoder()); err != nil {
|
||||
if err := kubectl.CreateOrUpdateAnnotation(cmdutil.GetFlagBool(cmd, cmdutil.ApplyAnnotationsFlag), info, f.JSONEncoder()); err != nil {
|
||||
return err
|
||||
}
|
||||
obj = info.Object
|
||||
|
||||
if !options.DryRun {
|
||||
obj, err = resource.NewHelper(client, mapping).Create(namespace, false, info.Object)
|
||||
if err != nil {
|
||||
|
Loading…
Reference in New Issue
Block a user