github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #65370 from deads2k/cli-78-delete-verb

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 65377, 63837, 65370, 65294, 65376). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

delete should tolerate a failed wait because of missing verbs

The power and ability to delete does not imply the power and ability to watch.  We correctly handled missing power (authz), but failed to account for ability (method not supported)

@kubernetes/sig-cli-maintainers 
@soltysh 

```release-note
Tolerate missing watch permission when deleting a resource
```
This commit is contained in:
Kubernetes Submit Queue
2018-06-22 16:16:11 -07:00
committed by GitHub
parent 32c3ffa19e 2c514b5b1d
commit a3fd45281a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/kubectl/cmd/delete.go
View File

@@ -285,7 +285,7 @@ func (o *DeleteOptions) DeleteResult(r *resource.Result) error {
IOStreams: o.IOStreams, IOStreams: o.IOStreams,
} }
err = waitOptions.RunWait() err = waitOptions.RunWait()
if errors.IsForbidden(err) { if errors.IsForbidden(err) || errors.IsMethodNotSupported(err) {
// if we're forbidden from waiting, we shouldn't fail. // if we're forbidden from waiting, we shouldn't fail.
glog.V(1).Info(err) glog.V(1).Info(err)
return nil return nil