From a53753575a2d4a0e0e8ec30dd9c45c85dceeded9 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Wed, 2 Nov 2022 15:21:16 +0100 Subject: [PATCH] e2e framework: stop overriding ginkgo verbosity/progress The default settings from Ginkgo are useful enough for Kubernetes since timeline support was added (https://github.com/onsi/ginkgo/issues/1069). --- test/e2e/framework/test_context.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/e2e/framework/test_context.go b/test/e2e/framework/test_context.go index 9e0ead5b20d..4fdcd0219cf 100644 --- a/test/e2e/framework/test_context.go +++ b/test/e2e/framework/test_context.go @@ -358,12 +358,8 @@ func RegisterCommonFlags(flags *flag.FlagSet) { func CreateGinkgoConfig() (types.SuiteConfig, types.ReporterConfig) { // fetch the current config suiteConfig, reporterConfig := ginkgo.GinkgoConfiguration() - // Turn on EmitSpecProgress to get spec progress (especially on interrupt) - suiteConfig.EmitSpecProgress = true // Randomize specs as well as suites suiteConfig.RandomizeAllSpecs = true - // Turn on verbose by default to get spec names - reporterConfig.Verbose = true // Disable skipped tests unless they are explicitly requested. if len(suiteConfig.FocusStrings) == 0 && len(suiteConfig.SkipStrings) == 0 { suiteConfig.SkipStrings = []string{`\[Flaky\]|\[Feature:.+\]`}