github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

More Lint Fixes

Browse Source
This commit is contained in:
Sharpz7 2023-08-17 17:19:46 +00:00
parent 601679446a
commit aa9f38c36d
1 changed files with 23 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
pkg/controller/job/job_controller_test.go
View File

@ -4706,6 +4706,7 @@ func (f *fakeRateLimitingQueue) AddAfter(item interface{}, duration time.Duratio
f.item = item f.item = item
f.duration = duration f.duration = duration
} }
func TestJobBackoff(t *testing.T) { func TestJobBackoff(t *testing.T) {
_, ctx := ktesting.NewTestContext(t) _, ctx := ktesting.NewTestContext(t)
logger := klog.FromContext(ctx) logger := klog.FromContext(ctx)
@ -4787,47 +4788,58 @@ func TestJobBackoffForOnFailure(t *testing.T) {
expectedConditionReason string expectedConditionReason string
}{ }{
"backoffLimit 0 should have 1 pod active": { "backoffLimit 0 should have 1 pod active": {
1, 1, 0, false, []int32{0}, v1.PodRunning, 1, 1, 0,
false, []int32{0}, v1.PodRunning,
1, 0, 0, nil, "", 1, 0, 0, nil, "",
}, },
"backoffLimit 1 with restartCount 0 should have 1 pod active": { "backoffLimit 1 with restartCount 0 should have 1 pod active": {
1, 1, 1, false, []int32{0}, v1.PodRunning, 1, 1, 1,
false, []int32{0}, v1.PodRunning,
1, 0, 0, nil, "", 1, 0, 0, nil, "",
}, },
"backoffLimit 1 with restartCount 1 and podRunning should have 0 pod active": { "backoffLimit 1 with restartCount 1 and podRunning should have 0 pod active": {
1, 1, 1, false, []int32{1}, v1.PodRunning, 1, 1, 1,
false, []int32{1}, v1.PodRunning,
0, 0, 1, &jobConditionFailed, "BackoffLimitExceeded", 0, 0, 1, &jobConditionFailed, "BackoffLimitExceeded",
}, },
"backoffLimit 1 with restartCount 1 and podPending should have 0 pod active": { "backoffLimit 1 with restartCount 1 and podPending should have 0 pod active": {
1, 1, 1, false, []int32{1}, v1.PodPending, 1, 1, 1,
false, []int32{1}, v1.PodPending,
0, 0, 1, &jobConditionFailed, "BackoffLimitExceeded", 0, 0, 1, &jobConditionFailed, "BackoffLimitExceeded",
}, },
"too many job failures with podRunning - single pod": { "too many job failures with podRunning - single pod": {
1, 5, 2, false, []int32{2}, v1.PodRunning, 1, 5, 2,
false, []int32{2}, v1.PodRunning,
0, 0, 1, &jobConditionFailed, "BackoffLimitExceeded", 0, 0, 1, &jobConditionFailed, "BackoffLimitExceeded",
}, },
"too many job failures with podPending - single pod": { "too many job failures with podPending - single pod": {
1, 5, 2, false, []int32{2}, v1.PodPending, 1, 5, 2,
false, []int32{2}, v1.PodPending,
0, 0, 1, &jobConditionFailed, "BackoffLimitExceeded", 0, 0, 1, &jobConditionFailed, "BackoffLimitExceeded",
}, },
"too many job failures with podRunning - multiple pods": { "too many job failures with podRunning - multiple pods": {
2, 5, 2, false, []int32{1, 1}, v1.PodRunning, 2, 5, 2,
false, []int32{1, 1}, v1.PodRunning,
0, 0, 2, &jobConditionFailed, "BackoffLimitExceeded", 0, 0, 2, &jobConditionFailed, "BackoffLimitExceeded",
}, },
"too many job failures with podPending - multiple pods": { "too many job failures with podPending - multiple pods": {
2, 5, 2, false, []int32{1, 1}, v1.PodPending, 2, 5, 2,
false, []int32{1, 1}, v1.PodPending,
0, 0, 2, &jobConditionFailed, "BackoffLimitExceeded", 0, 0, 2, &jobConditionFailed, "BackoffLimitExceeded",
}, },
"not enough failures": { "not enough failures": {
2, 5, 3, false, []int32{1, 1}, v1.PodRunning, 2, 5, 3,
false, []int32{1, 1}, v1.PodRunning,
2, 0, 0, nil, "", 2, 0, 0, nil, "",
}, },
"suspending a job": { "suspending a job": {
2, 4, 6, true, []int32{1, 1}, v1.PodRunning, 2, 4, 6,
true, []int32{1, 1}, v1.PodRunning,
0, 0, 0, &jobConditionSuspended, "JobSuspended", 0, 0, 0, &jobConditionSuspended, "JobSuspended",
}, },
"finshed job": { "finshed job": {
2, 4, 6, true, []int32{1, 1, 2, 0}, v1.PodSucceeded, 2, 4, 6,
true, []int32{1, 1, 2, 0}, v1.PodSucceeded,
0, 4, 0, &jobConditionComplete, "", 0, 4, 0, &jobConditionComplete, "",
}, },
} }