github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #125961 from Jerry-yz/master

Browse Source 
Chore: fix scheduler code comment typos
This commit is contained in:
Kubernetes Prow Robot
2024-07-15 19:27:30 -07:00
committed by GitHub
parent bfffd43108 bd90e99b2a
commit ae1caa40a2
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/scheduler/framework/interface.go
View File

@@ -363,7 +363,7 @@ type QueueSortPlugin interface {
// Failures from other extension points are regarded as temporal errors (e.g., network failure),
// and the scheduler requeue Pods without this extension point - always requeue Pods to activeQ after backoff.
// This is because such temporal errors cannot be resolved by specific cluster events,
// and we have no choise but keep retrying scheduling until the failure is resolved.
// and we have no choose but keep retrying scheduling until the failure is resolved.
//
// Plugins that make pod unschedulable (PreEnqueue, PreFilter, Filter, Reserve, and Permit plugins) should implement this interface,
// otherwise the default implementation will be used, which is less efficient in requeueing Pods rejected by the plugin.

2
pkg/scheduler/internal/queue/scheduling_queue.go
View File

@@ -112,7 +112,7 @@ type SchedulingQueue interface {
Done(types.UID)
Update(logger klog.Logger, oldPod, newPod *v1.Pod) error
Delete(pod *v1.Pod) error
// TODO(sanposhiho): move all PreEnqueueCkeck to Requeue and delete it from this parameter eventually.
// TODO(sanposhiho): move all PreEnqueueCheck to Requeue and delete it from this parameter eventually.
// Some PreEnqueueCheck include event filtering logic based on some in-tree plugins
// and it affect badly to other plugins.
// See https://github.com/kubernetes/kubernetes/issues/110175